Skip to content

Optional ORDER hints for SqlBulkCopy #540

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 42 commits into from
Jun 10, 2020
Merged

Optional ORDER hints for SqlBulkCopy #540

merged 42 commits into from
Jun 10, 2020

Conversation

johnnypham
Copy link
Contributor

@johnnypham johnnypham commented Apr 24, 2020 •
edited
Loading

For #23

ORDER ( { column [ ASC | DESC ] } [ ,... n ] ) Specifies how the data in the data file is sorted. Bulk import performance is improved if the data being imported is sorted according to the clustered index on the table, if any. If the data file is sorted in a different order, that is other than the order of a clustered index key or if there is no clustered index on the table, the ORDER clause is ignored. The column names supplied must be valid column names in the destination table. By default, the bulk insert operation assumes the data file is unordered. For optimized bulk import, SQL Server also validates that the imported data is sorted.

insert bulk, which SqlBulkCopy uses, will return an error message when an ORDER hint is given for an identity column and the query is not executed. This differs from BULK INSERT, which ignores the ORDER hint but still executes the query.

@johnnypham johnnypham added the Public API 🆕 Issues/PRs that introduce new APIs to the driver. label Apr 24, 2020
@dnfclas
Copy link

dnfclas commented Apr 24, 2020 •
edited
Loading

CLA assistant check
All CLA requirements met.

JRahnama
JRahnama reviewed Apr 27, 2020
View reviewed changes
DavoudEshtehari
DavoudEshtehari previously approved these changes Apr 28, 2020
View reviewed changes
@DavoudEshtehari DavoudEshtehari self-requested a review April 28, 2020 02:40
JRahnama
JRahnama reviewed Apr 28, 2020
View reviewed changes
@cheenamalhotra cheenamalhotra added this to the 2.0.0 milestone May 4, 2020
karinazhou
karinazhou reviewed May 5, 2020
View reviewed changes
David-Engel
David-Engel reviewed May 18, 2020
View reviewed changes
cheenamalhotra
cheenamalhotra reviewed Jun 4, 2020
View reviewed changes
DavoudEshtehari
DavoudEshtehari reviewed Jun 9, 2020
View reviewed changes
@cheenamalhotra cheenamalhotra merged commit 1be606c into dotnet:master Jun 10, 2020
@cheenamalhotra cheenamalhotra mentioned this pull request Jun 10, 2020
Closed
@johnnypham johnnypham deleted the bulkCopyOrderHints branch June 10, 2020 18:37
karinazhou pushed a commit to karinazhou/SqlClient that referenced this pull request Jun 10, 2020
@johnnypham @karinazhou
Optional ORDER hints for SqlBulkCopy (dotnet#540)
53a9e9f
@dependabot dependabot bot mentioned this pull request Jul 23, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cheenamalhotra cheenamalhotra cheenamalhotra approved these changes

@David-Engel David-Engel David-Engel left review comments

+3 more reviewers

@karinazhou karinazhou karinazhou left review comments

@JRahnama JRahnama JRahnama approved these changes

@DavoudEshtehari DavoudEshtehari DavoudEshtehari approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Public API 🆕 Issues/PRs that introduce new APIs to the driver.

Projects

None yet

Milestone

2.0.0

Development

Successfully merging this pull request may close these issues.

7 participants

@johnnypham @dnfclas @cheenamalhotra @David-Engel @karinazhou @JRahnama @DavoudEshtehari