[Release 1.1] Fix stored procedure issues introduced in v1.1.2 #545
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cheenamalhotra
force-pushed
the
1.1-fixSP
branch
from
81d9908 to
7647b74
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ports fix from PR #544 to 1.1-servicing
This PR revises fix introduced in #490 to address stored procedure concerns.
The check for
_attentionSentis applicable for both TDS Tokens DONEPROC and DONE, whereas, we only want to conditionally work when DONE_ATTN bit is received, which is validated whenHasReceivedAttentionis populated in the same flow.This seems like the right way to fix MARS TDS Header issue.
NuGet Package for testing:
Microsoft.Data.SqlClient.1.1.3-dev-pr545.nupkg.zip