Feature | Add support for Data Classification v2 #626
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduces Sensitivity Rank with Sensitivity Classification information
Wraith2
reviewed
Jun 25, 2020
src/Microsoft.Data.SqlClient/netfx/src/Microsoft/Data/SqlClient/SqlInternalConnectionTds.cs
Outdated
Show resolved
Hide resolved
Wraith2
reviewed
Jun 25, 2020
src/Microsoft.Data.SqlClient/netfx/src/Microsoft/Data/SqlClient/TdsEnums.cs
Outdated
Show resolved
Hide resolved
Wraith2
reviewed
Jun 25, 2020
src/Microsoft.Data.SqlClient/netfx/src/Microsoft/Data/SqlClient/TdsParser.cs
Outdated
Show resolved
Hide resolved
cheenamalhotra
added
the
Public API 🆕
src/Microsoft.Data.SqlClient/netfx/src/Microsoft/Data/SqlClient/TdsParser.cs
Outdated
Show resolved
Hide resolved
johnnypham
reviewed
Jul 6, 2020
doc/snippets/Microsoft.Data.SqlClient.DataClassification/SensitivityClassification.xml
Outdated
Show resolved
Hide resolved
cheenamalhotra
requested review from
DavoudEshtehari,
JRahnama,
johnnypham and
karinazhou
johnnypham
approved these changes
Jul 7, 2020
....Data.SqlClient/src/Microsoft/Data/SqlClient/DataClassification/SensitivityClassification.cs
Outdated
Show resolved
Hide resolved
DavoudEshtehari
approved these changes
Jul 16, 2020
JRahnama
approved these changes
Jul 16, 2020
karinazhou
reviewed
Jul 16, 2020
src/Microsoft.Data.SqlClient/netfx/ref/Microsoft.Data.SqlClient.cs
Outdated
Show resolved
Hide resolved
karinazhou
approved these changes
Jul 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces Sensitivity Rank with Sensitivity Classification information.
Additional Notes:
The driver supports Max version of v2. So if server only supports v1 , based on received version in FEATUREEXTACK packages, we do not read Sensitivity Rank. Only if server supports v2, we read this new Rank info. The Rank value for queries made on v1 server is "NOT DEFINED". This way the driver supports both v1 and v2 of Data Classification support from Server.
Testing has been done with both v1 and v2 servers.