Fix | MARS header contains errors on .NET Framework 4.8 #910
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cheenamalhotra
added
the
Public API 🆕
src/Microsoft.Data.SqlClient/netcore/src/Microsoft/Data/SqlClient/TdsParser.cs
Show resolved
Hide resolved
src/Microsoft.Data.SqlClient/netfx/src/Microsoft/Data/SqlClient/SqlConnectionFactory.cs
Show resolved
Hide resolved
src/Microsoft.Data.SqlClient/netfx/src/Microsoft/Data/SqlClient/LocalDBAPI.cs
Show resolved
Hide resolved
cheenamalhotra
approved these changes
Feb 19, 2021
cheenamalhotra
requested review from
DavoudEshtehari,
JRahnama,
johnnypham and
karinazhou
David-Engel
changed the title
David-Engel
commented
Feb 25, 2021
src/Microsoft.Data.SqlClient/netfx/src/Microsoft/Data/SqlClient/SqlException.cs
Show resolved
Hide resolved
JRahnama
reviewed
Feb 25, 2021
...Microsoft.Data.SqlClient/netfx/src/Microsoft/Data/SqlClient/LocalAppContextSwitches.netfx.cs
Show resolved
Hide resolved
JRahnama
reviewed
Feb 25, 2021
...Microsoft.Data.SqlClient/netfx/src/Microsoft/Data/SqlClient/LocalAppContextSwitches.netfx.cs
Show resolved
Hide resolved
|
LGTM. Couple of minor changes requested. Thank you @David-Engel. |
JRahnama
approved these changes
Feb 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing #85 MARS header contains errors for .NET Framework 4.8.
The underlying issue of why this was failing for .NET Framework 4.8 was that there was conditional logic on the default app context switch, MakeReadAsyncBlocking, setting it to false when the .NET runtime version was > 40702 (inherited from S.D.S netfx code). We don't need that complexity, so the app context code was cleaned up and made mostly common between netfx and netcore code.
This also brings parity to netcore for the existing MakeReadAsyncBlocking switch in netfx. It's already documented. We'll just need to update the doc to reflect that it is now available for .NET Core and .NET Standard, too:
https://docs.microsoft.com/en-us/sql/connect/ado-net/appcontext-switches?view=sql-server-ver15