[Mono.Android] build and reference non-PCL Java.Interop #2157
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonathanpeppers
changed the title
jonpryor
pushed a commit
to dotnet/java-interop
that referenced
this pull request
Sep 10, 2018
Context: dotnet/android#2157 We believe that we need commit 80b4f4e -- which removes the `XAIntegrationDebug` and `XAIntegrationRelease` configurations -- applied to xamarin/Java.Interop:d15-9 so that xamarin/xamarin-android:d15-9 will actually build.
jonathanpeppers
force-pushed
the
java.interop-not-pcl-15.9
branch
from
3578d75 to
7d790c6
Compare
Member
Author
|
APK tests failed: But I'm not seeing that previous error where |
Contributor
|
@jonathanpeppers: The file can't be found because the source file doesn't exist because the unit test process crashed: Ouch. Worse, there's no particular reason for the crash: I believe that this is in part why we have commit 7c51a91 / PR #2119, in the hopes that a newer emulator would at least provide more information about why things are crashing... |
Member
Author
|
Yeah, these XUnit tests worked fine for me locally... Here is the start of the test results from So I clicked |
Contributor
|
Same thing happened with the rebuild: Oddly, this time I don't see any |
jonpryor
added a commit
that referenced
this pull request
Sep 11, 2018
Context: #2157 Merge commit; cherry-picks the following commits from master: * d01e4ce (PR #2087): Revert "[mono-sdks] Use for android toolchain" * 7c51a91 (PR #2119): [tests] Update emulator to the latest version, switch to API 28 We're hoping that the emulator update will make unit test execution more reliable; see also PR #2157, which often has a crash when running some unit tests.
Fixes: http://work.devdiv.io/667174 Context: dotnet/java-interop@893562c Context: dotnet/java-interop@659711c Context: dotnet/java-interop@b873e81...9b390bc Bumped to java.interop/d15-9/9b390bc Build `lib\xamarin.android\xbuild-frameworks\MonoAndroid\v1.0\Java.Interop.dll` as a `MonoAndroid`-profile assembly instead of as a PCL assembly. This decreases the assemblies referenced in a "Hello World" Xamarin.Android project dramatically; this: Adding assembly reference for Java.Interop, Version=0.1.0.0, Culture=neutral, PublicKeyToken=84e04ff9cfb79065, recursively... Adding assembly reference for System.Runtime, Version=4.1.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a, recursively... Adding assembly reference for System.ComponentModel.Composition, Version=2.0.5.0, Culture=neutral, PublicKeyToken=b77a5c561934e089, recursively... Adding assembly reference for System.Diagnostics.Debug, Version=4.0.10.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a, recursively... Adding assembly reference for System.Threading, Version=4.0.10.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a, recursively... Adding assembly reference for System.Collections, Version=4.0.10.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a, recursively... Adding assembly reference for System.Collections.Concurrent, Version=4.0.10.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a, recursively... Adding assembly reference for System.Reflection, Version=4.1.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a, recursively... Adding assembly reference for System.Linq.Expressions, Version=4.1.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a, recursively... Adding assembly reference for System.Reflection.Primitives, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a, recursively... Adding assembly reference for System.Dynamic.Runtime, Version=4.0.10.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a, recursively... Adding assembly reference for System.ObjectModel, Version=4.0.10.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a, recursively... Adding assembly reference for System.Linq, Version=4.1.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a, recursively... Adding assembly reference for System.Runtime.InteropServices, Version=4.1.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a, recursively... Adding assembly reference for System.Runtime.Extensions, Version=4.1.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a, recursively... Adding assembly reference for System.Reflection.Extensions, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a, recursively... Adding assembly reference for Mono.Android, Version=0.0.0.0, Culture=neutral, PublicKeyToken=84e04ff9cfb79065, recursively... now becomes: Adding assembly reference for Java.Interop, Version=0.1.0.0, Culture=neutral, PublicKeyToken=84e04ff9cfb79065, recursively... Adding assembly reference for Mono.Android, Version=0.0.0.0, Culture=neutral, PublicKeyToken=84e04ff9cfb79065, recursively... Because fewer assemblies need to be resolved, the `Rebuild` target times improve by 30%-50% for the "Hello World" app: - `Debug` + PCL: 8.424s - `Debug` + *not* PCL: 4.258s (~50% faster!) - `Release` + PCL: 13.651s - `Release` + *not* PCL: 9.487s (~30% faster!) The `lib\xamarin.android\xbuild\Xamarin\Android\Java.Interop.dll` copy used by `Xamarin.Android.Build.Tasks.dll` remains unchanged, as it is referenced by `Xamarin.Android.Build.Tasks.csproj`.
jonathanpeppers
force-pushed
the
java.interop-not-pcl-15.9
branch
from
7d790c6 to
688f24e
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: http://work.devdiv.io/667174
Context: dotnet/java-interop@893562c
Context: dotnet/java-interop@659711c
Context: dotnet/java-interop@b873e81...9b390bc
Bumped to java.interop/d15-9/9b390bc
Build
lib\xamarin.android\xbuild-frameworks\MonoAndroid\v1.0\Java.Interop.dllas a
MonoAndroid-profile assembly instead of as a PCL assembly.This decreases the assemblies referenced in a "Hello World"
Xamarin.Android project dramatically; this:
now becomes:
Because fewer assemblies need to be resolved, the
Rebuildtargettimes improve by 30%-50% for the "Hello World" app:
Debug+ PCL: 8.424sDebug+ not PCL: 4.258s (~50% faster!)Release+ PCL: 13.651sRelease+ not PCL: 9.487s (~30% faster!)The
lib\xamarin.android\xbuild\Xamarin\Android\Java.Interop.dllcopy used by
Xamarin.Android.Build.Tasks.dllremains unchanged, asit is referenced by
Xamarin.Android.Build.Tasks.csproj.