[ci] Use unique storage URLs for installers #5313
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Commit b864f93 appears to have broken the GitHub status for the .NET 6 installers. These changes resulted in us attempting to use the same blob storage location for both legacy and .NET 6 installers, and the step which ran last (often legacy, as signing takes a while) would write over the previous status. Adding `net6` to the .NET 6 installer blob storage path should fix this.
Member
Author
|
When complete this build should create and post aritfacts statuses for both installer types, and should be used to confirm the fix: https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=4236920&view=results |
jonathanpeppers
approved these changes
Nov 18, 2020
Member
jonathanpeppers
left a comment
jonathanpeppers
left a comment
There was a problem hiding this comment.
The Github statuses I see currently seem like they worked.
The Queue Vsix Signing step is ongoing, so I'm not sure if that will affect anything.
Member
Author
|
All three statuses have now posted with live links, I'll merge this. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit b864f93 appears to have broken the GitHub status for the .NET 6
installers. These changes resulted in us attempting to use the same
blob storage location for both legacy and .NET 6 installers, and the
step which ran last (often legacy, as signing takes a while) would write
over the previous status. Adding
net6to the .NET 6 installer blobstorage path should fix this.