[Xamarin.Android.Build.Tasks] _CompileToDalvikWithDx invoked after modifying .cs file in a referenced library project #764
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonpryor
reviewed
Aug 21, 2017
| { | ||
| var name = AndroidXmlNamespace.GetName ("name"); | ||
| foreach (var node in nodes.Select (x => x as XElement)) { | ||
| var existing = element.XPathSelectElements ($"./{node.Name.LocalName}").Any (x => AttributesMatch (x, node)); |
There was a problem hiding this comment.
I don't see why this needs to use XPathSelectElements() when it's for a single element. Shouldn't element.Elements (node.Name) work?
There was a problem hiding this comment.
Be careful of any possible namespace prefixes in the argument name. The value should be really Name.LocalName (considering that meta-data element is in the default namespace).
It had better be indeed Elements() though; no need to kick XPath parser just for this.
dellis1972
force-pushed
the
Bug58865
branch
2 times, most recently
from
33e2576 to
989ae8a
Compare
…difying .cs file in a referenced library project Fixes https://bugzilla.xamarin.com/show_bug.cgi?id=58865 In this case the problem was being caused by the fact that the AndroidManifest.xml was constantly being modified. The item <meta-data android:name="android.support.VERSION" android:value="25.4.0" /> was constantly being duplicated in manifest. As a result it was always newer and was triggering a change of build targets. So we need to double check we are NOT adding 100% duplicate values to the manifest.
jonpryor
pushed a commit
to jonpryor/xamarin-android
that referenced
this pull request
Sep 11, 2017
…otnet#764) Fixes: https://bugzilla.xamarin.com/show_bug.cgi?id=58865 Consider a project with an `App.csproj` and a referenced `Lib.csproj`. Not all changes to C# sources within `Lib.csproj` should require rebuilding and redeploying the `.apk` when Fast Deployment is enabled; only those that result in changes to Java Callable Wrappers should require rebuilding and redeploying the `.apk`. Unfortunately, that wasn't the case: *any* change to `Lib.csproj` would result rebuilding and redeploying the `.apk`, because `AndroidManifest.xml` was constantly being modified, which would cause the `_CompileToDalvikWithDx` target to be invoked, resulting in a `.apk` rebuild + redeploy. The item <meta-data android:name="android.support.VERSION" android:value="25.4.0" /> was constantly being duplicated in the manifest. As a result it was always newer and was triggering a change of build targets. So we need to double check we are NOT adding 100% duplicate values to the manifest.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://bugzilla.xamarin.com/show_bug.cgi?id=58865
In this case the problem was being caused by the fact that the
AndroidManifest.xml was constantly being modified. The item
was constantly being duplicated in manifest. As a result it
was always newer and was triggering a change of build targets.
So we need to double check we are NOT adding 100% duplicate
values to the manifest.