-
Notifications
You must be signed in to change notification settings - Fork 379
Updating SDK and compiler versions to RC1 #10724
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
jkoritzinsky
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does Arcade merge-forward from the release branches to main, or do we need to put out a second PR for the main branch (as we should make this change there as well)?
Other than that, LGTM!
|
Should coordinate with @cston to make sure this has the |
Does not afaik. We probably need another PR targeting main. |
Please use Roslyn compiler build 4.4.0-3.22431.10 or later to include |
It looks like that compiler change is not included in RC1 after all. Please feel free to proceed with the RC1 compiler instead. |
|
Let’s make sure to open a PR against main with the same changes. |
|
@mmitche looks like this broke arcade-validation (https://github.com/dotnet/arcade-validation/pull/3357/checks?check_run_id=8240794806) due to something with the SDK version update, I'm taking a look. |
|
I think I see the problem and will push a commit to the validation pR |
Will do. I'll take care of this as soon as I'm done with propagating it in 7.0 |
This will update repos to use RC1 SDK and RC1 compilers for .NET 7. This is needed given the dotnet/runtime repo will now start to depend on these versions after dotnet/runtime#74822 goes in, so all upstack repos will need to get updated in order to get the dependency to flow.
cc: @mmitche @jaredpar @jkoritzinsky