Skip to content

Conversation

@joperezr
Copy link
Member

@joperezr joperezr commented Sep 1, 2022

This will update repos to use RC1 SDK and RC1 compilers for .NET 7. This is needed given the dotnet/runtime repo will now start to depend on these versions after dotnet/runtime#74822 goes in, so all upstack repos will need to get updated in order to get the dependency to flow.

cc: @mmitche @jaredpar @jkoritzinsky

Copy link
Member

@jkoritzinsky jkoritzinsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does Arcade merge-forward from the release branches to main, or do we need to put out a second PR for the main branch (as we should make this change there as well)?

Other than that, LGTM!

@jaredpar
Copy link
Member

jaredpar commented Sep 2, 2022

Should coordinate with @cston to make sure this has the RefSafeyRulesAttribute work

@ViktorHofer
Copy link
Member

Does Arcade merge-forward from the release branches to main, or do we need to put out a second PR for the main branch (as we should make this change there as well)?

Does not afaik. We probably need another PR targeting main.

@cston
Copy link
Contributor

cston commented Sep 6, 2022

Should coordinate with @cston to make sure this has the RefSafeyRulesAttribute work

Please use Roslyn compiler build 4.4.0-3.22431.10 or later to include RefSafetyRulesAttribute support. Thanks.

@cston
Copy link
Contributor

cston commented Sep 7, 2022

Please use Roslyn compiler build 4.4.0-3.22431.10 or later to include RefSafetyRulesAttribute support.

It looks like that compiler change is not included in RC1 after all. Please feel free to proceed with the RC1 compiler instead.

@mmitche mmitche enabled auto-merge (squash) September 7, 2022 22:42
@mmitche mmitche merged commit 72ccf7f into dotnet:release/7.0 Sep 8, 2022
@joperezr joperezr deleted the UpdatingToRC1 branch September 8, 2022 00:37
@jkoritzinsky
Copy link
Member

Let’s make sure to open a PR against main with the same changes.

@MattGal
Copy link
Member

MattGal commented Sep 8, 2022

@mmitche looks like this broke arcade-validation (https://github.com/dotnet/arcade-validation/pull/3357/checks?check_run_id=8240794806) due to something with the SDK version update, I'm taking a look.

@MattGal
Copy link
Member

MattGal commented Sep 8, 2022

I think I see the problem and will push a commit to the validation pR

@joperezr
Copy link
Member Author

joperezr commented Sep 8, 2022

Let’s make sure to open a PR against main with the same changes.

Will do. I'll take care of this as soon as I'm done with propagating it in 7.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants