Bump binlogtool #14361
Merged
Bump binlogtool #14361
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @premun - this is a prevention of issues after MSBuild update - similar to what needed to be firefighted before Christmas. Would it be possible to prioritize this within the team? |
premun
approved these changes
Jan 15, 2024
|
@JanKrivanek feel free to tag the dnceng team next time for more visibility |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FYI @KirillOsenkov
Context
This is update to the latest version of binlogtool, that contains the forward compatibility reading support.
The initial MSBuild change to forward compatible logs reading is breaking (log data format needs to be adjusted in order to allow forward compatibile reading for the future) - hence updating the reading code ahead of MSBuild pushing the updated version of binlog writing (dotnet/msbuild#9307) is advisable.
Once on this version - it should be possible to process future revisions of binlogs without need to upgrade the tool (unless a major cahnge is performed).
Job pushing the required package to the dnceng feed:
https://dev.azure.com/dnceng/internal/_build/results?buildId=2351197&view=results