- 
                Notifications
    
You must be signed in to change notification settings  - Fork 379
 
Add Microsoft.DotNet.Build.Tasks.SharedFramework.Sdk package #4030
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Merged
      
      
    
  
     Merged
                    Changes from all commits
      Commits
    
    
            Show all changes
          
          
            4 commits
          
        
        Select commit
          Hold shift + click to select a range
      
      
    File filter
Filter by extension
Conversations
          Failed to load comments.   
        
        
          
      Loading
        
  Jump to
        
          Jump to file
        
      
      
          Failed to load files.   
        
        
          
      Loading
        
  Diff view
Diff view
There are no files selected for viewing
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
        
          
          
            44 changes: 44 additions & 0 deletions
          
          44 
        
  ...t.Build.Tasks.SharedFramework.Sdk/Microsoft.DotNet.Build.Tasks.SharedFramework.Sdk.csproj
  
  
      
      
   
        
      
      
    
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              | Original file line number | Diff line number | Diff line change | 
|---|---|---|
| @@ -0,0 +1,44 @@ | ||
| <!-- Licensed to the .NET Foundation under one or more agreements. The .NET Foundation licenses this file to you under the MIT license. See the LICENSE file in the project root for more information. --> | ||
| <Project Sdk="Microsoft.NET.Sdk"> | ||
| <PropertyGroup> | ||
| <TargetFrameworks>net472;netcoreapp2.1</TargetFrameworks> | ||
| <LangVersion>preview</LangVersion> | ||
| <ExcludeFromSourceBuild>false</ExcludeFromSourceBuild> | ||
| 
     | 
||
| <IsPackable>true</IsPackable> | ||
| <GeneratePackageOnBuild>true</GeneratePackageOnBuild> | ||
| 
     | 
||
| <Description>Common toolset for building shared frameworks and framework packs.</Description> | ||
| <PackageType>MSBuildSdk</PackageType> | ||
| 
     | 
||
| <EnableDefaultNoneItems>false</EnableDefaultNoneItems> | ||
| <EnableGeneratedPackageContent>false</EnableGeneratedPackageContent> | ||
| <NoWarn>$(NoWarn);3021;NU5105</NoWarn> | ||
| 
     | 
||
| <DefaultItemExcludes Condition="'$(TargetFramework)' != 'net472'">**/*.Desktop.*</DefaultItemExcludes> | ||
| </PropertyGroup> | ||
| 
     | 
||
| <ItemGroup> | ||
| <PackageReference Include="Microsoft.Build.Tasks.Core" Version="$(MicrosoftBuildTasksCoreVersion)" /> | ||
| <PackageReference Include="Microsoft.Build" Version="$(MicrosoftBuildVersion)" /> | ||
| <PackageReference Include="Microsoft.Extensions.DependencyModel" Version="$(MicrosoftExtensionsDependencyModelVersion)" /> | ||
| <PackageReference Include="NuGet.Packaging" Version="$(NuGetVersion)" /> | ||
| <PackageReference Include="NuGet.ProjectModel" Version="$(NuGetVersion)" /> | ||
| <PackageReference Include="NuGet.Versioning" Version="$(NuGetVersion)" /> | ||
| </ItemGroup> | ||
| 
     | 
||
| <ItemGroup> | ||
| <None Include="sdk/**/*.*" Pack="true"> | ||
| <PackagePath>sdk/%(RecursiveDir)%(Filename)%(Extension)</PackagePath> | ||
| </None> | ||
| <None Include="targets/**/*.*" Pack="true"> | ||
| <PackagePath>targets/%(RecursiveDir)%(Filename)%(Extension)</PackagePath> | ||
| </None> | ||
| </ItemGroup> | ||
| 
     | 
||
| <ItemGroup> | ||
| <Compile Include="..\Common\AssemblyResolution.cs" Link="src\AssemblyResolution.cs" /> | ||
| </ItemGroup> | ||
| 
     | 
||
| <Import Project="$(RepoRoot)eng\BuildTask.targets" /> | ||
| </Project> | ||
        
          
          
            29 changes: 29 additions & 0 deletions
          
          29 
        
  src/Microsoft.DotNet.Build.Tasks.SharedFramework.Sdk/README.md
  
  
      
      
   
        
      
      
    
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              | Original file line number | Diff line number | Diff line change | 
|---|---|---|
| @@ -0,0 +1,29 @@ | ||
| # Microsoft.DotNet.Build.Tasks.SharedFramework.Sdk | ||
| 
     | 
||
| Common toolset for building shared frameworks and framework packs. Handles | ||
| projects with extensions: | ||
| 
     | 
||
| * `depproj` | ||
| * Restores dependencies and run crossgen. | ||
| * `pkgproj` | ||
| * Generates NuGet packages and various installers: Windows `msi`, macOS `pkg`, | ||
| Debian packages, RPM packages, and the `tar.gz` and `zip` archives. | ||
| * `sfxproj` | ||
| * Generates the shared framework ("runtime") itself, its installers, and its | ||
| compressed archives. | ||
| * `bundleproj` | ||
| * Generates bundle installers: Windows `exe`. | ||
| * There is a macOS bundle `pkg`, however it is not produced by this package as | ||
| of writing. | ||
| 
     | 
||
| Framework packs are targeting packs, apphost packs, and runtime packs. See the | ||
| design at https://github.com/dotnet/designs/pull/50. | ||
| 
     | 
||
| This package is a migration of tooling previously living in the | ||
| [Core-Setup](https://github.com/dotnet/core-setup) repository, without any | ||
| significant improvements. | ||
| [arcade#2704](https://github.com/dotnet/arcade/issues/2704) tracks improving it | ||
| to the point where it's reasonable to onboard new repos. | ||
| 
     | 
||
| This package depends on `Microsoft.DotNet.Build.Tasks.Packaging` for NuGet | ||
| package creation and validation tooling. | 
        
          
          
            26 changes: 26 additions & 0 deletions
          
          26 
        
  src/Microsoft.DotNet.Build.Tasks.SharedFramework.Sdk/sdk/Sdk.props
  
  
      
      
   
        
      
      
    
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              | Original file line number | Diff line number | Diff line change | 
|---|---|---|
| @@ -0,0 +1,26 @@ | ||
| <Project> | ||
| 
     | 
||
| <!-- | ||
| Like the Arcade SDK, this SDK doesn't import its dependencies here like a typical SDK would. | ||
| Rather, the repo must import the Arcade SDK and the Arcade SDK's dependencies. | ||
| 
     | 
||
| See https://github.com/dotnet/arcade/blob/238f1bbb23ba67616818d0b242c5b55a18edec55/Documentation/ArcadeSdk.md#directorybuildprops | ||
| --> | ||
| 
     | 
||
| <PropertyGroup Condition="'$(DotNetBuildTasksSharedFrameworkTaskDir)' == ''"> | ||
| <DotNetBuildTasksSharedFrameworkTaskDir Condition="'$(MSBuildRuntimeType)' == 'core'">$(MSBuildThisFileDirectory)../tools/netcoreapp2.1/</DotNetBuildTasksSharedFrameworkTaskDir> | ||
| <DotNetBuildTasksSharedFrameworkTaskDir Condition="'$(MSBuildRuntimeType)' != 'core'">$(MSBuildThisFileDirectory)../tools/net472/</DotNetBuildTasksSharedFrameworkTaskDir> | ||
| </PropertyGroup> | ||
| 
     | 
||
| <PropertyGroup> | ||
| <DotNetBuildTasksSharedFrameworkTaskFile>$(DotNetBuildTasksSharedFrameworkTaskDir)Microsoft.DotNet.Build.Tasks.SharedFramework.Sdk.dll</DotNetBuildTasksSharedFrameworkTaskFile> | ||
| </PropertyGroup> | ||
| 
     | 
||
| <!-- Allow setting a property to use targets from a development dir for faster iteration. --> | ||
| <PropertyGroup> | ||
| <DotNetBuildTasksSharedFrameworkMSBuildDir Condition="'$(DotNetBuildTasksSharedFrameworkMSBuildDir)' == ''">$(MSBuildThisFileDirectory)..\targets\</DotNetBuildTasksSharedFrameworkMSBuildDir> | ||
| </PropertyGroup> | ||
| 
     | 
||
| <Import Project="$(DotNetBuildTasksSharedFrameworkMSBuildDir)packaging-tools.props" /> | ||
| 
     | 
||
| </Project> | 
        
          
          
            12 changes: 12 additions & 0 deletions
          
          12 
        
  src/Microsoft.DotNet.Build.Tasks.SharedFramework.Sdk/sdk/Sdk.targets
  
  
      
      
   
        
      
      
    
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              | Original file line number | Diff line number | Diff line change | 
|---|---|---|
| @@ -0,0 +1,12 @@ | ||
| <Project> | ||
| 
     | 
||
| <!-- | ||
| Like the Arcade SDK, this SDK doesn't import its dependencies here like a typical SDK would. | ||
| Rather, the repo must import the Arcade SDK and the Arcade SDK's dependencies. | ||
| 
     | 
||
| See https://github.com/dotnet/arcade/blob/238f1bbb23ba67616818d0b242c5b55a18edec55/Documentation/ArcadeSdk.md#directorybuildprops | ||
| --> | ||
| 
     | 
||
| <Import Project="$(DotNetBuildTasksSharedFrameworkMSBuildDir)packaging-tools.targets" /> | ||
| 
     | 
||
| </Project> | 
      
      Oops, something went wrong.
        
    
  
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
Uh oh!
There was an error while loading. Please reload this page.