Skip to content

Conversation

@JamesNK
Copy link
Member

@JamesNK JamesNK commented Jul 7, 2025

Description

  • Add TelemetryComponentIds with constants for component telemetry IDs
  • Add telemetry to interaction components

Checklist

  • Is this feature complete?
    • Yes. Ready to ship.
    • No. Follow-up changes expected.
  • Are you including unit tests for the changes and scenario tests if relevant?
    • Yes
    • No
  • Did you add public API?
    • Yes
      • If yes, did you have an API Review for it?
        • Yes
        • No
      • Did you add <remarks /> and <code /> elements on your triple slash comments?
        • Yes
        • No
    • No
  • Does the change make any security assumptions or guarantees?
    • Yes
      • If yes, have you done a threat model and had a security review?
        • Yes
        • No
    • No
  • Does the change require an update in our Aspire docs?

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Adds telemetry identifiers and instrumentation across dashboard pages, controls, and interactions to centralize component telemetry.

  • Introduces TelemetryComponentIds with named constants for pages and controls
  • Replaces hard-coded nameof(...) strings with TelemetryComponentIds references in page/control components
  • Extends InteractionsProvider to generate and dispose ComponentTelemetryContext for dialogs and message bars

Reviewed Changes

Copilot reviewed 14 out of 14 changed files in this pull request and generated 2 comments.

File Description
src/Aspire.Dashboard/Telemetry/TelemetryComponentIds.cs New static class defining component telemetry identifiers
src/Aspire.Dashboard/Components/Pages/*.razor.cs Updated TelemetryContext initialization to use constants
src/Aspire.Dashboard/Components/Controls/*.razor.cs Updated control telemetry context to use constants
src/Aspire.Dashboard/Components/Interactions/InteractionsProvider.cs Added telemetry context creation/disposal for interactions
Comments suppressed due to low confidence (1)

src/Aspire.Dashboard/Telemetry/TelemetryComponentIds.cs:6

  • No unit tests were added for the new TelemetryComponentIds constants or the telemetry initialization logic in InteractionsProvider. Consider adding tests to validate constant values and that telemetry contexts are created, initialized, and disposed as expected.
public static class TelemetryComponentIds

@adamint adamint merged commit d2e654f into main Jul 9, 2025
252 checks passed
@adamint adamint deleted the jamesnk/telemetry-interaction-service branch July 9, 2025 19:17
@danmoseley
Copy link
Member

/backport to release/9.4

@github-actions
Copy link
Contributor

Started backporting to release/9.4: https://github.com/dotnet/aspire/actions/runs/16207876810

@github-actions github-actions bot locked and limited conversation to collaborators Aug 10, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants