-
Notifications
You must be signed in to change notification settings - Fork 715
[release/9.4] Mark ParameterResource.Value as obsolete in favor of GetValueAsync and direct usage #10701
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: davidfowl <[email protected]>
… ParameterResource values Co-authored-by: davidfowl <[email protected]>
…value resolution Co-authored-by: davidfowl <[email protected]>
Co-authored-by: davidfowl <[email protected]>
Co-authored-by: davidfowl <[email protected]>
…scope resolution Co-authored-by: davidfowl <[email protected]>
…instead of obsolete Value property Co-authored-by: davidfowl <[email protected]>
Co-authored-by: davidfowl <[email protected]>
…age in AzurePublishingContext Co-authored-by: davidfowl <[email protected]>
…roperty Co-authored-by: davidfowl <[email protected]>
Co-authored-by: davidfowl <[email protected]>
joperezr
approved these changes
Jul 28, 2025
eerhardt
approved these changes
Jul 28, 2025
|
Merging now to get this in for 9.4 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
area-app-model
Issues pertaining to the APIs in Aspire.Hosting, e.g. DistributedApplication
Re-opened Github-Action PR
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #10363 to release/9.4
/cc @mitchdenny @copilot
Customer Impact
This PR obsoletes the
ParameterResource.Valueproperty and instructs users to useParameterResource.GetValueAsync(...). There are some related changes in the Azure, Kubernetes, and Docker integration packages as a result.Testing
Unit tests pass. Tested parameter behaviors with Azure and Docker publishing.
Risk
Moderate.
Regression?