-
Notifications
You must be signed in to change notification settings - Fork 725
Set up extension build and sign pipeline #11504
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
adamint
merged 27 commits into
dotnet:main
from
adamint:dev/adamint/extension-loc-build-sign
Sep 23, 2025
Merged
Changes from all commits
Commits
Show all changes
27 commits
Select commit
Hold shift + click to select a range
f0f1a7d
first try extension CI
adamint c4186d0
move above other stages
adamint 5740e21
install vsce globally before package
adamint 24c7c40
explicitly publish extension
adamint 17ee0bf
try add signing
adamint 8006a85
try #2
adamint 05676ac
Revert "try #2"
adamint e87d402
try to fix sign
adamint b6ed70e
try with artifacts packages dir property
adamint 17a2d4a
remove verification
adamint 671994f
clean up
adamint 106ed3a
pr suggestions
adamint fc2f4c1
run stages in parallel
adamint 131be2c
see if this runs in parallel
adamint 76a9e33
add restore back
adamint d6d73a3
rename binlog
adamint 13dfc8a
remove extra upload step
adamint 36c5577
Merge remote-tracking branch 'origin/main' into dev/adamint/extension…
radical e1cd165
Move building extension to msbuild from the scripts. And always build…
radical 4d1c4b5
fix typo
radical 33131d5
fix build
radical 98110e7
Don't try to parse errors and warnings from yarn/npm invocations. Onl…
radical ff14ebc
try publishing vsix
adamint a85e80c
update paths
adamint e178308
update paths 2
adamint c929b66
Revert "update paths 2"
adamint 5d72d08
fix path to publish..?
adamint File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,58 @@ | ||
| <Project Sdk="Microsoft.Build.NoTargets"> | ||
| <PropertyGroup> | ||
| <TargetFramework>$(DefaultTargetFramework)</TargetFramework> | ||
| <ExtensionSrcDir>$(MSBuildThisFileDirectory)</ExtensionSrcDir> | ||
| </PropertyGroup> | ||
|
|
||
| <Target Name="BuildAndPackageExtension" BeforeTargets="Build" DependsOnTargets="CheckYarnInstalled;CheckVsceInstalled"> | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. For future PRs it would be useful to add Inputs/Outputs to the targets, so this can be skipped on incremental builds. It would be useful if you are doing it locally. |
||
| <PropertyGroup> | ||
| <_PackageJsonPath>$([MSBuild]::NormalizePath($(ExtensionSrcDir), 'package.json'))</_PackageJsonPath> | ||
| <_VsixPath>$([MSBuild]::NormalizePath($(ArtifactsPackagesDir), 'aspire-vscode-$(Version).vsix'))</_VsixPath> | ||
| </PropertyGroup> | ||
|
|
||
| <Error Text="$(_PackageJsonPath) not found. Cannot package the extension." Condition="!Exists('$(_PackageJsonPath)')" /> | ||
|
|
||
| <!-- Extract version from package.json using Node.js --> | ||
| <Exec Command="node -p "require('./package.json').version"" | ||
| ConsoleToMSBuild="true" | ||
| IgnoreStandardErrorWarningFormat="true" | ||
| WorkingDirectory="$(ExtensionSrcDir)"> | ||
| <Output TaskParameter="ConsoleOutput" PropertyName="_ExtractedVersion" /> | ||
| </Exec> | ||
|
|
||
| <!-- Install dependencies and compile --> | ||
| <Exec Command="yarn install" WorkingDirectory="$(ExtensionSrcDir)" IgnoreStandardErrorWarningFormat="true" /> | ||
| <Exec Command="yarn compile" WorkingDirectory="$(ExtensionSrcDir)" IgnoreStandardErrorWarningFormat="true" /> | ||
|
|
||
| <!-- Make extension directory --> | ||
| <MakeDir Directories="$(ArtifactsPackagesDir)\vscode" /> | ||
|
|
||
| <!-- Package extension --> | ||
| <Exec Command="vsce package --pre-release --out $(ArtifactsPackagesDir)\vscode\aspire-vscode-$(_ExtractedVersion).vsix" | ||
| IgnoreStandardErrorWarningFormat="true" | ||
| WorkingDirectory="$(ExtensionSrcDir)" /> | ||
| </Target> | ||
|
|
||
| <Target Name="CheckYarnInstalled"> | ||
| <Exec Command="yarn --version" ContinueOnError="true" ConsoleToMSBuild="true" IgnoreStandardErrorWarningFormat="true"> | ||
| <Output TaskParameter="ExitCode" PropertyName="YarnExitCode" /> | ||
| <Output TaskParameter="ConsoleOutput" PropertyName="YarnVersion" /> | ||
| </Exec> | ||
|
|
||
| <Error Condition="'$(YarnExitCode)' != '0'" Text="yarn is not installed or not available in PATH. To build the extension, install yarn: https://yarnpkg.com/getting-started/install" /> | ||
|
|
||
| <Message Importance="high" Text="yarn version: $(YarnVersion)" /> | ||
| </Target> | ||
|
|
||
| <Target Name="CheckVsceInstalled"> | ||
| <Exec Command="vsce --version" ContinueOnError="true" ConsoleToMSBuild="true" IgnoreStandardErrorWarningFormat="true"> | ||
| <Output TaskParameter="ExitCode" PropertyName="VsceExitCode" /> | ||
| <Output TaskParameter="ConsoleOutput" PropertyName="VsceVersion" /> | ||
| </Exec> | ||
|
|
||
| <Error Condition="'$(VsceExitCode)' != '0'" Text="vsce is not installed or not available in PATH. To build the extension, install vsce: npm install -g vsce" /> | ||
|
|
||
| <Message Text="Found vsce version: $(VsceVersion)" /> | ||
| </Target> | ||
|
|
||
| </Project> | ||
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file (and build.sh) shouldn't have been changed for this, as we shouldn't touch files under eng\common. Those get overwritten by arcade each time we update, so this shouldn't be modified, and instead we should change the files under eng\build.ps1/sh. Last night we took an arcade update which broke the build as these scripts where replaced.
cc: @adamint @radical
Fyi: @davidfowl who was asking about this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I fixed that up in the update-arcade Pr.