- 
                Notifications
    You must be signed in to change notification settings 
- Fork 715
Display help text for GenAI sensitive data when no messages #11656
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR fixes the display logic for GenAI help text in the Aspire Dashboard. Previously, help text for sensitive data was only shown when messages existed but had no content. Now it also displays when no messages are present at all, which occurs when Microsoft.Extensions.AI doesn't output message telemetry due to disabled sensitive data settings.
- Updates the AllMessagesHaveNoContentmethod to returntruewhen there are no messages
- Adds comprehensive test coverage for the no-messages scenario
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description | 
|---|---|
| src/Aspire.Dashboard/Model/GenAI/GenAIVisualizerDialogViewModel.cs | Modified logic to show help text when no messages are present | 
| tests/Aspire.Dashboard.Tests/Model/GenAIVisualizerDialogViewModelTests.cs | Added test case to verify help text displays when no messages exist | 
| 🚀 Dogfood this PR with: 
 curl -fsSL https://raw.githubusercontent.com/dotnet/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 11656Or 
 iex "& { $(irm https://raw.githubusercontent.com/dotnet/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 11656" | 
| @JamesNK this is not getting backported right? | 
| /backport to 9.5 | 
| Started backporting to 9.5: https://github.com/dotnet/aspire/actions/runs/18027514307 | 
| @JamesNK an error occurred while backporting to "9.5", please check the run log for details! The process '/usr/bin/git' failed with exit code 1 | 
| /backport to release/9.5 | 
| Started backporting to release/9.5: https://github.com/dotnet/aspire/actions/runs/18027523371 | 
Description
MEAI changed how it writes telemetry in the latest version. If sensitive data isn't enabled then MEAI telemetry doesn't output any messages. Unfortunatly the help text only displays if there are messages with no content, but not when there are no messages at all.
PR changes that logic to display help text when there are no messages:
Checklist
<remarks />and<code />elements on your triple slash comments?doc-ideatemplatebreaking-changetemplatediagnostictemplate