-
Notifications
You must be signed in to change notification settings - Fork 707
[release/9.5] Support parameter names with dashes resolved from underscore configuration #11802
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: davidfowl <[email protected]>
… keys Co-authored-by: davidfowl <[email protected]>
Co-authored-by: davidfowl <[email protected]>
…normalization Co-authored-by: davidfowl <[email protected]>
Co-authored-by: davidfowl <[email protected]>
… non-empty values Co-authored-by: davidfowl <[email protected]>
Co-authored-by: davidfowl <[email protected]>
…istinguish configured from generated values Co-authored-by: davidfowl <[email protected]>
Co-authored-by: davidfowl <[email protected]>
…onfiguration Co-authored-by: davidfowl <[email protected]>
Co-authored-by: davidfowl <[email protected]>
…files Co-authored-by: captainsafia <[email protected]>
|
🚀 Dogfood this PR with:
curl -fsSL https://raw.githubusercontent.com/dotnet/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 11802Or
iex "& { $(irm https://raw.githubusercontent.com/dotnet/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 11802" |
captainsafia
approved these changes
Oct 2, 2025
joperezr
approved these changes
Oct 2, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes are not very scoped, but they look good and this is important for the deploy scenario. Approved for 9.5.1
This was referenced Oct 24, 2025
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #11785 to release/9.5
/cc @captainsafia @copilot
Customer Impact
Customers cannot set the state of parameters via environment variables in some cases which make it hard to use in a CI pipeline.
Testing
Manual and Automatic.
Risk
Low.
Regression?
No