Extract Aspire.Hosting.Nats.Tests project #5002
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
area-codeflow
dotnet-policy-service
bot
added
the
community-contribution
20 tasks
eerhardt
reviewed
Jul 22, 2024
radical
reviewed
Jul 23, 2024
radical
reviewed
Jul 23, 2024
| else | ||
| { | ||
| bindMountPath = Path.Combine(Path.GetTempPath(), Path.GetRandomFileName()); | ||
| nats1.WithDataBindMount(bindMountPath); |
Member
There was a problem hiding this comment.
Just curious - WithDataBindMount is mounting to /var/lib/nats in the container. How is this test hitting that?
radical
added
area-app-model
eerhardt
reviewed
Jul 29, 2024
eerhardt
approved these changes
Jul 29, 2024
Member
eerhardt
left a comment
eerhardt
left a comment
There was a problem hiding this comment.
LGTM. Thanks again for the contributions!
Contributor
Author
it's pleasure. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to #3185
Contributes to #4294
Microsoft Reviewers: Open in CodeFlow