Skip to content

Conversation

@Zombach
Copy link
Contributor

@Zombach Zombach commented Jul 24, 2024

Initial issues #2649
Issues Check List: Validate arguments of public methods

Microsoft Reviewers: Open in CodeFlow

@ghost ghost added the area-codeflow for labeling automated codeflow. intentionally a different color! label Jul 24, 2024
@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label Jul 24, 2024
@Zombach Zombach changed the title Fix CA1062#Aspire.Hosting.Redis CA1062#Aspire.Hosting.Redis Jul 24, 2024
@Zombach
Copy link
Contributor Author

Zombach commented Jul 24, 2024

@mitchdenny
Hello, could you take a look?

@radical radical added area-app-model Issues pertaining to the APIs in Aspire.Hosting, e.g. DistributedApplication and removed area-codeflow for labeling automated codeflow. intentionally a different color! labels Jul 24, 2024
Copy link
Member

@mitchdenny mitchdenny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for working on this!

@mitchdenny mitchdenny merged commit ced70f6 into dotnet:main Jul 29, 2024
@Zombach Zombach deleted the zombach/validate-arguments-of-public-methods#aspire-hosting-redis branch July 29, 2024 05:52
@github-actions github-actions bot locked and limited conversation to collaborators Aug 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-app-model Issues pertaining to the APIs in Aspire.Hosting, e.g. DistributedApplication community-contribution Indicates that the PR has been added by a community member

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants