[release/9.0] Fix spans not hidden on expand/collapse #6397
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Open
3 tasks
drewnoakes
approved these changes
Oct 21, 2024
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Visible bug on high traffic page + regression. Approved. |
joperezr
approved these changes
Oct 21, 2024
|
@JamesNK Any automation that can be added to catch this in the future? Perhaps in form of a playwright test? Particularly curious as this is depending on fluent controls that can get updated without us noticing these breaks. |
|
(The above question doesn't block this PR so I'm merging anyway) |
Yeah, a playwright test could probably have caught this. The downside is it's pretty difficult to write a test for this, and full coverage is a lot of tests. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #6394 to release/9.0
Fixes #6393
/cc @JamesNK
Customer Impact
Expand/collapse buttons on the trace details page don't update the data grid. Clicking on the expand/collapse does nothing. Users are unable to hide data they don't want to see.
Testing
Manual testing
Risk
Low
Regression?
Yes, this worked in 8.2. A FluentUI update during 9.0 changed how data grid updates are handled and this situation wasn't updated to make it work.
Microsoft Reviewers: Open in CodeFlow