Skip to content

Fix regression with AddConnectionSting #7500

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 10, 2025
Merged

Fix regression with AddConnectionSting #7500

merged 1 commit into from
Feb 10, 2025

Conversation

@davidfowl
Copy link
Member

Description

  • After Fix AddConnectionString for tests #7327, AddConnectionString was generating a value.v0 resource instead of a parameter.v0. This fixes the order of evaluation so that parameters are preferred over IResourceWithConnectionString.

Checklist

  • Is this feature complete?
    • Yes. Ready to ship.
    • No. Follow-up changes expected.
  • Are you including unit tests for the changes and scenario tests if relevant?
    • Yes
    • No
  • Did you add public API?
    • No
  • Does the change make any security assumptions or guarantees?
    • No
  • Does the change require an update in our Aspire docs?
    • No

@davidfowl
Fix regression with AddConnectionSting
aca200b 
- After #7327, AddConnectionStrnig was generating a value.v0 resource instead of a parameter.v0. This fixes the order of evaluation so that parameters are preferred over IResourceWithConnectionString.
@davidfowl davidfowl requested review from JamesNK and eerhardt and removed request for mitchdenny February 10, 2025 07:44
@eerhardt eerhardt merged commit 0ab5904 into main Feb 10, 2025
70 checks passed
@eerhardt eerhardt deleted the davidfowl/fix-regressionin-addcs branch February 10, 2025 14:34
@davidfowl davidfowl mentioned this pull request Feb 13, 2025
Merged
4 tasks
@github-actions github-actions bot added the area-app-model Issues pertaining to the APIs in Aspire.Hosting, e.g. DistributedApplication label Mar 10, 2025
@github-actions github-actions bot locked and limited conversation to collaborators Apr 9, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@eerhardt eerhardt eerhardt approved these changes

@JamesNK JamesNK Awaiting requested review from JamesNK

Assignees

No one assigned

Labels

area-app-model Issues pertaining to the APIs in Aspire.Hosting, e.g. DistributedApplication

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@davidfowl @eerhardt