Skip to content

Added WithEnvironment overload supporting Keyvault secret refs #8821

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 16, 2025
Merged

Added WithEnvironment overload supporting Keyvault secret refs #8821

merged 2 commits into from
Apr 16, 2025

Conversation

@davidfowl
Copy link
Member

Description

  • Added tests
  • Moved KV tests to a new file

Contributes to #2587

Checklist

  • Is this feature complete?
    • Yes. Ready to ship.
    • No. Follow-up changes expected.
  • Are you including unit tests for the changes and scenario tests if relevant?
    • Yes
    • No
  • Did you add public API?
    • Yes
  • Does the change make any security assumptions or guarantees?
    • No
  • Does the change require an update in our Aspire docs?
    • Yes

@davidfowl
Added WithEnvironment overload supporting Keyvault refs
0023d5c 
- Added tests
- Moved KV tests to a new file
@github-actions github-actions bot added the area-integrations Issues pertaining to Aspire Integrations packages label Apr 16, 2025
@davidfowl davidfowl requested a review from eerhardt April 16, 2025 15:40
@davidfowl davidfowl changed the title Added WithEnvironment overload supporting Keyvault refs Added WithEnvironment overload supporting Keyvault secret refs Apr 16, 2025
eerhardt
eerhardt approved these changes Apr 16, 2025
View reviewed changes
Copy link
Member

@eerhardt eerhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@davidfowl
[test] Enhance WithEnvironment_AddsKeyVaultSecretReference to validat…
7e986e6 
…e environment variables for both Run and Publish modes
@davidfowl davidfowl merged commit 85cef9b into main Apr 16, 2025
174 checks passed
@davidfowl davidfowl deleted the davidfowl/kvsecret branch April 16, 2025 18:09
@IEvangelist
Copy link
Member

@davidfowl - this isn't helpful. No link, no issue.
image

@davidfowl
Copy link
Member Author

lol. Do we want docs links for new API? Seems like it would be more efficient to bulk API review and decide which things need articles and which ones are just new APIs

@davidfowl davidfowl mentioned this pull request May 13, 2025
Merged
@github-actions github-actions bot locked and limited conversation to collaborators May 18, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@eerhardt eerhardt eerhardt approved these changes

Assignees

No one assigned

Labels

area-integrations Issues pertaining to Aspire Integrations packages

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@davidfowl @IEvangelist @eerhardt