Skip to content

Fix console page not matching resource for non-running resources #8917

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 23, 2025
Merged

Fix console page not matching resource for non-running resources #8917

merged 1 commit into from
Apr 23, 2025

Conversation

@JamesNK
Copy link
Member

@JamesNK JamesNK commented Apr 22, 2025 •
edited
Loading

Fix regression. The option display name is no longer used to match or be persisted.

Fixes #8831

Checklist

  • Is this feature complete?
    • Yes. Ready to ship.
    • No. Follow-up changes expected.
  • Are you including unit tests for the changes and scenario tests if relevant?
    • Yes
    • No
  • Did you add public API?
    • Yes
      • If yes, did you have an API Review for it?
        • Yes
        • No
      • Did you add <remarks /> and <code /> elements on your triple slash comments?
        • Yes
        • No
    • No
  • Does the change make any security assumptions or guarantees?
    • Yes
      • If yes, have you done a threat model and had a security review?
        • Yes
        • No
    • No
  • Does the change require an update in our Aspire docs?

JamesNK
JamesNK commented Apr 23, 2025
View reviewed changes
src/Aspire.Dashboard/Components/Controls/ResourceSelectOptionTemplate.razor
{
<div style="width: 20px;"></div>
<span aria-label="@string.Format(@Loc[nameof(ControlsStrings.ResourceDropdownReplicaAccessibleTitle)], ViewModel.Name, ViewModel.Id.ReplicaSetName)">@ViewModel.Name</span>
<span style="padding-left: 20px;" aria-label="@string.Format(@Loc[nameof(ControlsStrings.ResourceDropdownReplicaAccessibleTitle)], ViewModel.Name, ViewModel.Id.ReplicaSetName)">@ViewModel.Name</span>
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed the div+width was compressed when the display name is long. padding is always applied.

@JamesNK JamesNK merged commit 8fd92af into main Apr 23, 2025
175 checks passed
@JamesNK JamesNK deleted the jamesnk/console-resource-name branch April 23, 2025 09:15
@github-actions github-actions bot locked and limited conversation to collaborators May 24, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@mitchdenny mitchdenny mitchdenny approved these changes

@adamint adamint Awaiting requested review from adamint

@eerhardt eerhardt Awaiting requested review from eerhardt

@karolz-ms karolz-ms Awaiting requested review from karolz-ms

Assignees

No one assigned

Labels

area-dashboard

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Console logs friendly url regression

3 participants

@JamesNK @mitchdenny