Revert "Wait for dashboard to be healthy before returning URL via RPC." #9038
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
area-app-model
danmoseley
approved these changes
Apr 30, 2025
|
It's worth unpacking why no tests failed 😄. I think we need a single cli smoke test to catch this level of regression |
mitchdenny
deleted the
revert-9027-mitchdenny/devcontainer-dashboard-portforwarding-bug
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #9027
It stopped the CLI working. I'll tomorrow morning as to why it happened. It looks like the WaitForResourceHealthyAsync method is waiting indefinately - but its not the health check that is the problem (happens even without the health check wired up).