Decouple hidden resource attribute from state #9063
Conversation
|
|
||
| internal static class ResourceViewModelExtensions | ||
| { | ||
| public static bool IsHiddenState(this ResourceViewModel resource) |
There was a problem hiding this comment.
I think we keep this for now so hidden resources don't suddenly start showing up. We can still infer hidden from this.
There was a problem hiding this comment.
Added a method IsHidden that also checks for Hidden state.
| public static Task WaitForResources(this DistributedApplication app, IEnumerable<string>? targetStates = null, CancellationToken cancellationToken = default) | ||
| { | ||
| targetStates ??= [KnownResourceStates.Running, KnownResourceStates.Hidden]; | ||
| targetStates ??= [KnownResourceStates.Running]; |
|
Should showing hidden resources also show those with |
|
I think you should make 3 changes:
This would help us asses the risk of breaking more easily. |
|
I agree with @davidfowl. This is a good change overall but we need to deliver the changes in small chunks. The first stage is to unlock code running inside the app host to allow it to check for running state of hidden resources (so separating hiddenness from state). That is a big enough change for one PR and then I think adding support for showing hidden resources in the dashboard would be a welcome change - but should come later. Doing this incrementally with small tight PRs will get this change in faster. (p.s. I was so happy when I saw you picked this up overnight @adamint !) |
I can't think of a reason it shouldn't. Were you thinking of any scenario in particular? |
4 participants
Description
Adds a new
hiddenfield to the resource proto definition and refactors everywhere thatKnownResourceStates.Hiddenwas used in apphost and dashboard. Also adds a toggle to show/hide hidden resources in the dashboard on the console logs and resources page.ex:
Fixes #8428
Checklist
<remarks />and<code />elements on your triple slash comments?doc-ideatemplatebreaking-changetemplatediagnostictemplate