Don't include ref assembly from Microsoft.AspNetCore.Testing #18803
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
area-infrastructure
Member
👍 |
JunTaoLuo
approved these changes
Feb 5, 2020
dougbu
approved these changes
Feb 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The 3.1.0 Extensions ref pack should not have included a ref assembly for
Microsoft.AspNetCore.Testing. Excluding it here is easier than re-building the ref pack, and is required to ingest dotnet/extensions#2936 (which removes that ref project). Part of dotnet/extensions#2784.Proof-of-concept here: #18720
@dougbu @JunTaoLuo PTAL
CC @Pilchie - marking this as infra-tell-mode for 3.1.3 as it's an extension of dotnet/extensions#2936