Added request size limit value to exception message in case of request body large exception for Kestrel

[ShreyasJejurkar]

Fixes #4773

[halter73]

@MCCshreyas do you think you'll have time to come back to this? If not, no worries.

[ShreyasJejurkar]

Hi @halter73, Sorry for the delay!
I will get this done and checked this weekend!

Thanks!

[ShreyasJejurkar]

@davidfowl Can you please tell me the command via which the resource method gets autogenerated with parameter? I have updated the resource string with the parameter, now I need to generate its corresponding method!

Thanks!

[davidfowl]

@davidfowl Can you please tell me the command via which the resource method gets autogenerated with parameter? I have updated the resource string with the parameter, now I need to generate its corresponding method!

@dougbu can you help out here? Is there a doc on how you generate resx? I recall it was build.cmd resx but I don't think there's a build in this solution folder anymore

[dougbu]

Is there a doc on how you generate resx?

See https://github.com/dotnet/aspnetcore/blob/main/docs/BuildFromSource.md#resx-files

Note the generated files aren't usually checked in and the resources are compiled during builds.

[davidfowl]

@MCCshreyas are you going to finish this?

[davidfowl]

@MCCshreyas are you going to finish this change?

[ShreyasJejurkar]

Yeah, this weekend.

[ShreyasJejurkar]

@dougbu Not sure why I am getting this error. Am running this command from the same folder where the csproj is

[davidfowl]

Your command looks wrong. Do this:

dotnet msbuild /t:Resgen

You have typo: t:/Resgen instead of /t:Resgen, you also don't need to specify the project file, that folder only has one.

[ShreyasJejurkar]

Thanks, @davidfowl, It worked. Seems like a typo in docs! Lol. I will get that fixed that as well!

[davidfowl]

##[error]src/Servers/Kestrel/Core/src/Internal/Http/MessageBody.cs(179,98): error CA1305: (NETCORE_ENGINEERING_TELEMETRY=Build) The behavior of 'long.ToString()' could vary based on the current user's locale settings. Replace this call in 'MessageBody.AddAndCheckObservedBytes(long)' with a call to 'long.ToString(IFormatProvider)'.

[ShreyasJejurkar]

@davidfowl, I was looking for example, on how people have passed string argument to this one, but they were having an argument in string type already, but in my case, MaxBodyRequestSize is in long?, so anyhow I need to convert that before passing!

So to pass the instance of IFormatProvider should I take a constructor dependency for this or the method dependency? Any example for me to refer to in the existing codebase! Or it is ok to pass CultureInfo.InvariantCulture?

Thanks!

[davidfowl]

InvariantCulture is what you want

[halter73]

Thanks!

[halter73]

@MCCshreyas I also saw your reddit post about minimal hosting. Thanks for putting the word out!

[ShreyasJejurkar]

No worries, @halter73. Just putting some initial awareness about new features! 😅😅
Atleast I can do that! 😇😇