Skip to content

Fix race in FrameAfterTrailers_UnexpectedFrameError #31061

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
1 commit merged into from
Mar 19, 2021
Merged

Fix race in FrameAfterTrailers_UnexpectedFrameError #31061

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/Servers/Kestrel/test/InMemory.FunctionalTests/Http3/Http3StreamTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1685,6 +1685,10 @@ public async Task FrameAfterTrailers_UnexpectedFrameError()
var requestStream = await InitializeConnectionAndStreamsAsync(_noopApplication);

await requestStream.SendHeadersAsync(headers, endStream: false);

// The app no-ops quickly. Wait for it here so it's not a race with the error response.
await requestStream.ExpectHeadersAsync();

await requestStream.SendDataAsync(Encoding.UTF8.GetBytes("Hello world"));
await requestStream.SendHeadersAsync(trailers, endStream: false);
await requestStream.SendDataAsync(Encoding.UTF8.GetBytes("This is invalid."));
Expand Down