Skip to content

Increase KestrelServerLimits.KeepAliveTimeout to 130 seconds #32636

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
2 commits merged into from
May 14, 2021
Merged

Increase KestrelServerLimits.KeepAliveTimeout to 130 seconds #32636

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c512ca4
Increase KestrelServerLimits.KeepAliveTimeout to 130 seconds
halter73 May 13, 2021
dd28f11
Fix KeepAliveTimeoutDefault test
halter73 May 13, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions src/Servers/Kestrel/Core/src/KestrelServerLimits.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,8 +33,9 @@ public class KestrelServerLimits
// Matches the default LimitRequestFields in Apache httpd.
private int _maxRequestHeaderCount = 100;

// Matches the default http.sys connectionTimeout.
private TimeSpan _keepAliveTimeout = TimeSpan.FromMinutes(2);
// Slightly more than SocketHttpHandler's old PooledConnectionIdleTimeout of 2 minutes.
// https://github.com/dotnet/runtime/issues/52267
private TimeSpan _keepAliveTimeout = TimeSpan.FromSeconds(130);

private TimeSpan _requestHeadersTimeout = TimeSpan.FromSeconds(30);

Expand Down Expand Up @@ -169,7 +170,7 @@ public long? MaxRequestBodySize

/// <summary>
/// Gets or sets the keep-alive timeout.
/// Defaults to 2 minutes.
/// Defaults to 130 seconds.
/// </summary>
/// <remarks>
/// </remarks>
Expand Down
2 changes: 1 addition & 1 deletion src/Servers/Kestrel/Core/test/KestrelServerLimitsTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,7 +150,7 @@ public void MaxRequestHeaderCountValid(int value)
[Fact]
public void KeepAliveTimeoutDefault()
{
Assert.Equal(TimeSpan.FromMinutes(2), new KestrelServerLimits().KeepAliveTimeout);
Assert.Equal(TimeSpan.FromSeconds(130), new KestrelServerLimits().KeepAliveTimeout);
}

[Theory]
Expand Down