Minimal APIs - return string aren't setting content type header #33860 #34285
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rafikiassumani-msft
requested review from
BrennanConroy and
Tratcher
as code owners
ghost
added
area-runtime
community-contribution
|
|
Tratcher
reviewed
Jul 12, 2021
src/Http/Http.Abstractions/src/Extensions/ContentTypeConstants.cs
Outdated
Show resolved
Hide resolved
src/Http/Http.Abstractions/src/Extensions/HttpResponseWritingExtensions.cs
Outdated
Show resolved
Hide resolved
halter73
reviewed
Jul 12, 2021
src/Http/Http.Abstractions/test/HttpResponseWritingExtensionsTests.cs
Outdated
Show resolved
Hide resolved
BrennanConroy
removed
the
community-contribution
halter73
reviewed
Jul 13, 2021
halter73
reviewed
Jul 13, 2021
halter73
reviewed
Jul 13, 2021
halter73
reviewed
Jul 13, 2021
halter73
reviewed
Jul 13, 2021
rafikiassumani-msft
force-pushed
the
plainText
branch
from
f330658 to
6848dc0
Compare
halter73
reviewed
Jul 15, 2021
halter73
reviewed
Jul 15, 2021
halter73
approved these changes
Jul 15, 2021
pranavkm
reviewed
Jul 15, 2021
Co-authored-by: Stephen Halter <[email protected]>
pranavkm
approved these changes
Jul 15, 2021
halter73
reviewed
Jul 15, 2021
halter73
reviewed
Jul 15, 2021
halter73
reviewed
Jul 15, 2021
halter73
reviewed
Jul 15, 2021
halter73
reviewed
Jul 15, 2021
auto-merge was automatically disabled
July 15, 2021 19:34
Head branch was pushed to by a user without write access
amcasey
added
area-networking
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set Content Type to Plain Text if ContextType Response header is not set
This change will set the contextType response header to "text/plain; charset=utf-8" when the content-type response header is null or was not set.
Addresses #33860