Skip to content

Remove try/catch around IsSupported property #41123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 11, 2022
Merged

Remove try/catch around IsSupported property #41123

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 1 addition & 15 deletions src/Servers/Kestrel/Transport.Quic/src/WebHostBuilderQuicExtensions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ public static class WebHostBuilderQuicExtensions
/// <returns>The <see cref="IWebHostBuilder"/>.</returns>
public static IWebHostBuilder UseQuic(this IWebHostBuilder hostBuilder)
{
if (IsQuicSupported())
if (QuicImplementationProviders.Default.IsSupported)
{
return hostBuilder.ConfigureServices(services =>
{
Expand All @@ -44,18 +44,4 @@ public static IWebHostBuilder UseQuic(this IWebHostBuilder hostBuilder, Action<Q
services.Configure(configureOptions);
});
}

private static bool IsQuicSupported()
{
try
{
return QuicImplementationProviders.Default.IsSupported;
}
catch (PlatformNotSupportedException)
{
// On some platforms, System.Net.Quic is just a stub assembly in which every method throws PlatformNotSupportedException,
// including the QuicImplementationProviders.Default.IsSupported getter.
return false;
}
}
}