Stop shipping packages for assemblies which are shared-framework-only #4178
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
natemcmaster
commented
Nov 21, 2018
Tratcher
reviewed
Nov 21, 2018
Co-Authored-By: natemcmaster <[email protected]>
ryanbrandenburg
approved these changes
Nov 21, 2018
natemcmaster
added
the
breaking-change
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #3756.
The removes the need to ship packages for assemblies which are part of Microsoft.AspNetCore.App. The implementation of this requires first building packages, and then modifying .nuspec's and categorizing packages as "noship".
This can be improved after we finish merging all git submodules. Once that is done, we can replace PackageReference's with ProjectReference's and avoid producing "turd" .nupkg's altogether. Also, once NuGet implements NuGet/Home#7342, we can use FrameworkReference to build our packages.