Skip to content

Conversation

@pavelsavara
Copy link
Member

@pavelsavara pavelsavara commented Feb 8, 2023

Summary

This unifies the startup sequence with the runtime.

Contributes to dotnet/runtime#74346
Depends on dotnet/runtime#81886

Changes

  • we create runtime instance using the new create API
  • DLLs and PDBs are loaded by runtime
  • timezone data is loaded by runtime
  • ICU data is filtered by Blazor and loaded by runtime
  • environment variables are set by the new API
  • Blazor._internal is initialized after runtime instance creation
  • reorganized order of methods in the file for better readability
  • disabled runtime's feature throttling of parallel downloads

Fixes

  • fixed setting LANG environment based on applicationCulture option even if ICU is not sharded to make it work according to docs
  • improved ICU test LoadingApp_KoreanLanguage_Works

Should still work as before

  • download progress bar
  • resourceLoader (cache)
  • lazy and satellite assemblies

Out of scope

@pavelsavara pavelsavara added area-blazor Includes: Blazor, Razor Components feature-blazor-wasm This issue is related to and / or impacts Blazor WebAssembly labels Feb 8, 2023
@pavelsavara pavelsavara added this to the 8.0 milestone Feb 8, 2023
@pavelsavara pavelsavara self-assigned this Feb 8, 2023
@pavelsavara pavelsavara marked this pull request as ready for review February 17, 2023 13:57
@pavelsavara pavelsavara requested a review from a team as a code owner February 17, 2023 13:57
Copy link
Member

@ilonatommy ilonatommy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good from my perspective.

Copy link
Member

@MackinnonBuck MackinnonBuck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 🙂

Copy link
Member

@maraf maraf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area-blazor Includes: Blazor, Razor Components feature-blazor-wasm This issue is related to and / or impacts Blazor WebAssembly

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants