Skip to content

[RDG] Support serializing polymorphic response types with STJ #46791

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Mar 3, 2023
Merged

[RDG] Support serializing polymorphic response types with STJ #46791

merged 4 commits into from
Mar 3, 2023

Conversation

@brunolins16
Copy link
Member

@brunolins16 brunolins16 commented Feb 22, 2023 •
edited
Loading

Fixes #46297

@ghost ghost added the area-runtime label Feb 22, 2023
captainsafia
captainsafia reviewed Feb 22, 2023
View reviewed changes
@brunolins16 brunolins16 changed the title Brunolins16/minimal/sourcegen/46297 [RDG] Support serializing polymorphic response types with STJ Feb 24, 2023
@brunolins16 brunolins16 added old-area-web-frameworks-do-not-use *DEPRECATED* This label is deprecated in favor of the area-mvc and area-minimal labels and removed area-runtime labels Feb 24, 2023
@brunolins16 brunolins16 marked this pull request as ready for review February 24, 2023 18:43
@build-analysis build-analysis bot mentioned this pull request Feb 24, 2023
Closed
5 tasks
@captainsafia captainsafia force-pushed the brunolins16/minimal/sourcegen/46297 branch 2 times, most recently from 2e00d68 to db15278 Compare March 1, 2023 22:31
@build-analysis build-analysis bot mentioned this pull request Mar 1, 2023
Open
5 tasks
@captainsafia captainsafia force-pushed the brunolins16/minimal/sourcegen/46297 branch 2 times, most recently from aef3171 to 28731ca Compare March 1, 2023 23:29
@captainsafia
Copy link
Member

@mitchdenny Can you take a look at this?

@captainsafia captainsafia requested a review from mitchdenny March 1, 2023 23:39
mitchdenny
mitchdenny approved these changes Mar 2, 2023
View reviewed changes
Copy link
Member

@mitchdenny mitchdenny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Only real comment is around CodeWriter but you may want to defer that for another PR so you can get this in.

@captainsafia captainsafia force-pushed the brunolins16/minimal/sourcegen/46297 branch from 28731ca to dcd7e0b Compare March 3, 2023 07:04
@captainsafia captainsafia merged commit 39f36e7 into dotnet:main Mar 3, 2023
@ghost ghost added this to the 8.0-preview3 milestone Mar 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@captainsafia captainsafia captainsafia left review comments

@mitchdenny mitchdenny mitchdenny approved these changes

@Tratcher Tratcher Awaiting requested review from Tratcher

@BrennanConroy BrennanConroy Awaiting requested review from BrennanConroy BrennanConroy is a code owner

@halter73 halter73 Awaiting requested review from halter73 halter73 is a code owner

Assignees

No one assigned

Labels

old-area-web-frameworks-do-not-use *DEPRECATED* This label is deprecated in favor of the area-mvc and area-minimal labels

Projects

None yet

Milestone

8.0-preview3

Development

Successfully merging this pull request may close these issues.

Support serializing polymorphic response types with STJ in RequestDelegateGenerator

3 participants

@brunolins16 @captainsafia @mitchdenny