Skip to content

Annotate histograms with bucket boundaries #56500

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 30, 2024
Merged

Annotate histograms with bucket boundaries #56500

merged 3 commits into from
Jun 30, 2024

Conversation

@JamesNK
Copy link
Member

@JamesNK JamesNK commented Jun 28, 2024

Fixes #53359

@JamesNK JamesNK added the area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions label Jun 28, 2024
@JamesNK JamesNK mentioned this pull request Jun 28, 2024
Closed
@JamesNK
Copy link
Member Author

JamesNK commented Jun 28, 2024

cc @noahfalk @tarekgh

@JamesNK JamesNK mentioned this pull request Jun 28, 2024
Closed
JamesNK
JamesNK commented Jun 28, 2024
View reviewed changes
@build-analysis build-analysis bot mentioned this pull request Jun 28, 2024
Closed
3 tasks
tarekgh
tarekgh approved these changes Jun 28, 2024
View reviewed changes
Copy link
Member

@tarekgh tarekgh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

noahfalk
noahfalk approved these changes Jun 29, 2024
View reviewed changes
Copy link
Member

@noahfalk noahfalk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as well (also glad in general to see the advice API fitting smoothly into existing code)

@noahfalk
Copy link
Member

fyi @samsp-msft

@JamesNK
Copy link
Member Author

JamesNK commented Jun 30, 2024

/azp run

@JamesNK JamesNK enabled auto-merge (squash) June 30, 2024 00:11
@azure-pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@JamesNK JamesNK merged commit d301328 into main Jun 30, 2024
@JamesNK JamesNK deleted the jamesnk/histogram-boundaries branch June 30, 2024 02:15
@dotnet-policy-service dotnet-policy-service bot added this to the 9.0-preview7 milestone Jun 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@noahfalk noahfalk noahfalk approved these changes

@tarekgh tarekgh tarekgh approved these changes

@BrennanConroy BrennanConroy Awaiting requested review from BrennanConroy BrennanConroy is a code owner

@halter73 halter73 Awaiting requested review from halter73 halter73 is a code owner

@mgravell mgravell Awaiting requested review from mgravell

+1 more reviewer

@Kielek Kielek Kielek approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions

Projects

None yet

Milestone

9.0-preview7

Development

Successfully merging this pull request may close these issues.

Add bucket size hints to histograms

5 participants

@JamesNK @noahfalk @Kielek @tarekgh