Don't throw exception for parameters with custom binding source #59035
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
captainsafia
requested review from
BrennanConroy,
DeagleGross and
mikekistler
ghost
added
the
area-mvc
1 task
BrennanConroy
changed the title
...Core.OpenApi.Tests/Services/OpenApiDocumentService/OpenApiDocumentServiceTests.Parameters.cs
Outdated
Show resolved
Hide resolved
BrennanConroy
approved these changes
Nov 19, 2024
mikekistler
reviewed
Nov 19, 2024
...Core.OpenApi.Tests/Services/OpenApiDocumentService/OpenApiDocumentServiceTests.Parameters.cs
Outdated
Show resolved
Hide resolved
|
/backport to release/9.0 |
|
Started backporting to release/9.0: https://github.com/dotnet/aspnetcore/actions/runs/12384353552 |
10 tasks
captainsafia
added a commit
that referenced
this pull request
Feb 11, 2025
* Don't through exception for parameters with custom binding source * Default to ParameterLocation.Query for ambiguous source
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #59013.
We can probably afford to be more lax here. One thing to note is that this means that users will have to do the due diligence to set the parameter location themselves via transformers since we can't figure out this information implicitly.
Also, if users want to specify custom binder for a parameter that is actually from the body, they will need to define the binding source correctly on the model binder so that the argument appears under the
requestBodyfield of the operation instead of theparametersfield.