Don't run IIS websocket tests on unsupported queue #59036
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BrennanConroy
added
the
area-networking
BrennanConroy
requested review from
JamesNK,
halter73 and
mgravell
as code owners
adityamandaleeka
approved these changes
Nov 18, 2024
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
BrennanConroy
commented
Nov 19, 2024
src/Servers/IIS/IIS/test/Common.FunctionalTests/Infrastructure/IISTestSiteFixture.cs
Outdated
Show resolved
Hide resolved
…/IISTestSiteFixture.cs
captainsafia
pushed a commit
that referenced
this pull request
Feb 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Shortly after pushing #58846 the daily Helix runs started consistently failing on IIS.FunctionalTests. It looks like it fails the tests that are using IISTestSiteFixture, and the only modification to that file was adding the websocket module. Looking at the failing helix queue, IIS websockets doesn't look like it's enabled so it's probably failing to start the server application due to use arbitrarily adding the module.
I've asked if we can enable websockets on the helix queue, but in the meantime we can try avoiding this problem when running on that queue.