This repository was archived by the owner on Jan 23, 2023. It is now read-only.
[R2R][RyuJit][ARM] Fix R2R relative indirection for arm. #16171
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ARM R2R calls that are indirected through a relative address are dispatched as VSD using virtualStubParamInfo->GetReg() for indirection cell address, which ZapIndirectHelperThunk expects.
For VSD we add this argument in morph, do the same for this case.
So this PR:
call->IsR2RRelativeIndir()on ARMcellAddr->gtRegNum = REG_R2R_INDIRECT_PARAM;fgValueNumberHelperCallFuncto accept the R2R arm helpers with non-standard number of arguments.Fix #16589.