This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Enabling CLR implemented write watch on AMD64 on Windows. #16516
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkotas
reviewed
Feb 23, 2018
| add_definitions(-DFEATURE_UNIX_AMD64_STRUCT_PASSING) | ||
| endif (CLR_CMAKE_PLATFORM_UNIX_AMD64) | ||
| add_definitions(-DFEATURE_USE_ASM_GC_WRITE_BARRIERS) | ||
| if(CLR_CMAKE_PLATFORM_ARCH_AMD64 OR (CLR_CMAKE_PLATFORM_ARCH_ARM64 AND NOT WIN32)) |
Member
There was a problem hiding this comment.
Should we have a bug to enable this for Windows ARM64 as well?
jkotas
approved these changes
Feb 23, 2018
sywhang
approved these changes
Feb 23, 2018
Member
Author
|
@dotnet-bot test Tizen armel Cross Checked Innerloop Build and Test |
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To keep in sync with Desktop, this enables using CLR implemented write watch on AMD64 on Windows in addition to Linux. Manually managed card bundle will still be using the OS implemented write watch on Windows.
@sywhang @jkotas