Skip to content
This repository was archived by the owner on Jan 23, 2023. It is now read-only.

Conversation

@robertmclaws
Copy link

  • Introduce an AddRange function that waits until all new items are added to the collection before firing OnCollectionChanged.
  • Moved a helper method out of the "Constructors" section for organizational clarity.

- Introduce an AddRange function that waits until all new items are added to the collection before firing OnCollectionChanged.
- Moved a helper method out of the "Constructors" section for organizational clarity.
@dnfclas
Copy link

dnfclas commented Aug 13, 2016

Hi @advancedrei, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution!

In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes. I promise there's no faxing. https://cla2.dotnetfoundation.org.

TTYL, DNFBOT;

@dnfclas
Copy link

dnfclas commented Aug 13, 2016

@advancedrei, Thanks for signing the contribution license agreement so quickly! Actual humans will now validate the agreement and then evaluate the PR.

Thanks, DNFBOT;

@weshaggard
Copy link
Member

@advancedrei lets please follow the process at http://aka.ms/apireview for adding new APIs.

@robertmclaws
Copy link
Author

robertmclaws commented Aug 13, 2016

Oops, sorry @weshaggard. I'll open an issue. (UPDATE: It's open).

@stephentoub
Copy link
Member

Thanks for the contribution. Per @weshaggard's comments and the issue you opened, I'm going to close this PR until the API is agreed upon. At that point this PR or a new one can be re-opened.

@karelz karelz modified the milestone: 1.2.0 Dec 3, 2016
justinvp referenced this pull request in robertmclaws/coreclr Dec 4, 2016
@weitzhandler
Copy link

Here's a prototype that I use. It's a subclass of ObservableCollection and is an enhancement of this. I find some of the original functionality redundant, but it updates the UI fast for me. I was facing a scenario where the collection updates ~5 times per second. Reusing items was essential.

@weitzhandler
Copy link

weitzhandler commented Aug 31, 2017

@robertmclaws
Are you still working on it or planning to? Otherwise I'd like to take over.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants