This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Remove unnecessary disables of SQL tests #21648
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephentoub
approved these changes
Jun 28, 2017
saurabh500
approved these changes
Jun 28, 2017
Contributor
|
Is there a PR for the ILC fix? |
Member
Author
|
@saurabh500 no, because I'm not sure what it was (note they're in TFS). These crashes were deterministic, and we reported them to ILC folks, so I'm assuming they fxied whatever it was. |
Contributor
|
Thank you |
safern
reviewed
Jun 28, 2017
Member
safern
left a comment
safern
left a comment
There was a problem hiding this comment.
LGTM. I'm excited to see that we are now actually fixing issues and re-enabling tests.
Thanks @danmosemsft
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
Commit migrated from dotnet/corefx@ad697e0
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ILC issue is now fixed.
Fixes https://github.com/dotnet/corefx/issues/19202