Skip to content
This repository was archived by the owner on Jan 23, 2023. It is now read-only.

Fix HttpClient sending fragment portion of uri on request #32574

Merged
merged 5 commits into from
Oct 4, 2018
Merged

Fix HttpClient sending fragment portion of uri on request #32574

merged 5 commits into from
Oct 4, 2018

Conversation

@MarcoRossignoli
Copy link
Member

@MarcoRossignoli MarcoRossignoli commented Oct 2, 2018

@MarcoRossignoli
Copy link
Member Author

MarcoRossignoli commented Oct 2, 2018

@dotnet-bot test Outerloop Linux x64 Debug Build
@dotnet-bot test Outerloop Linux x64 Release Build please
@dotnet-bot test Outerloop UWP CoreCLR x64 Debug Build
@dotnet-bot test Outerloop Windows x64 Debug Build

@davidsh
Copy link
Contributor

davidsh commented Oct 3, 2018

@dotnet-bot test Outerloop Linux x64 Debug Build
@dotnet-bot test Outerloop Linux x64 Release Build please
@dotnet-bot test Outerloop UWP CoreCLR x64 Debug Build
@dotnet-bot test Outerloop Windows x64 Debug Build

@MarcoRossignoli
Copy link
Member Author

MarcoRossignoli commented Oct 3, 2018

@davidsh sorry...i missed your outerloops launch...refresh issue.

@MarcoRossignoli
Copy link
Member Author

MarcoRossignoli commented Oct 4, 2018

@dotnet-bot test this please

@MarcoRossignoli
Copy link
Member Author

MarcoRossignoli commented Oct 4, 2018

@dotnet-bot test Outerloop Linux x64 Debug Build
@dotnet-bot test Outerloop Linux x64 Release Build please
@dotnet-bot test Outerloop UWP CoreCLR x64 Debug Build
@dotnet-bot test Outerloop Windows x64 Debug Build

@MarcoRossignoli
Copy link
Member Author

MarcoRossignoli commented Oct 4, 2018

@dotnet-bot test Outerloop Linux x64 Debug Build
@dotnet-bot test Outerloop Linux x64 Release Build please
@dotnet-bot test Outerloop UWP CoreCLR x64 Debug Build
@dotnet-bot test Outerloop Windows x64 Debug Build

@MarcoRossignoli
Copy link
Member Author

MarcoRossignoli commented Oct 4, 2018 •
edited
Loading

@davidsh i fixed tests and run ci...fail seems unrelated.

davidsh
davidsh approved these changes Oct 4, 2018
View reviewed changes
Copy link
Contributor

@davidsh davidsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the PR!

@davidsh davidsh merged commit 87a944a into dotnet:master Oct 4, 2018
@davidsh davidsh added this to the 3.0 milestone Oct 4, 2018
@MarcoRossignoli MarcoRossignoli deleted the httpclientfragment branch October 19, 2018 18:22
picenka21 pushed a commit to picenka21/runtime that referenced this pull request Feb 18, 2022
@MarcoRossignoli @davidsh
Fix HttpClient sending fragment portion of uri on request (dotnet/cor…
eed59da 
…efx#32574)

Fixes dotnet/corefx#32378


Commit migrated from dotnet/corefx@87a944a
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@stephentoub stephentoub stephentoub approved these changes

@davidsh davidsh davidsh approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

area-System.Net.Http

Projects

None yet

Milestone

3.0

Development

Successfully merging this pull request may close these issues.

HttpClient sending fragment portion of uri on request

3 participants

@MarcoRossignoli @davidsh @stephentoub