Skip to content
This repository was archived by the owner on Jan 23, 2023. It is now read-only.

Conversation

@ayakael
Copy link

@ayakael ayakael commented Dec 17, 2021

Contributes to dotnet/core#6985
I havn't seen this popup yet, so here is a merge request to add RID for Alpine 3.15. Tell me if I'm stepping on your toes @wfurt, I'll close it if so :).

Made as part of Alpine Linux dotnet31 / dotnet5 packaging project, see dotnet/source-build#2695

@ayakael ayakael changed the title Add RID for Alpine 3.15 [release/3.1]Add RID for Alpine 3.15 Dec 17, 2021
@wfurt
Copy link
Member

wfurt commented Jan 18, 2022

This is not sufficient for servicing. We also need to make the packaging changes. Look at #43099 @ayakael
cc: @Anipik @safern

@ayakael
Copy link
Author

ayakael commented Jan 21, 2022

Many thanks, will do!

@ayakael ayakael force-pushed the alpine/add-rid-315 branch from e10ada8 to d17b719 Compare January 21, 2022 18:42
@ayakael
Copy link
Author

ayakael commented Jan 21, 2022

Made the changes, pushing to 3.1.10, and rebased.

@wfurt wfurt mentioned this pull request Jan 26, 2022
12 tasks
Copy link
Member

@wfurt wfurt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Do we need anything else @safern?

@wfurt wfurt added the Servicing-consider Issue for next servicing release review label Jan 26, 2022
@leecow leecow added Servicing-approved Approved for servicing release and removed Servicing-consider Issue for next servicing release review labels Jan 27, 2022
@leecow leecow modified the milestones: 5.0.14, 3.1.24 Jan 27, 2022
@carlossanlop
Copy link

carlossanlop commented Mar 8, 2022

Branch is now open for merging servicing-approved changes.

@wfurt thank you for reminding to make the OOB packaging changes as well.

@wfurt @ayakael are we confident the CI failures are unrelated to this change? I see they only happened in Windows legs, so I assume we're ok, but wanted to double check with you.

@wfurt
Copy link
Member

wfurt commented Mar 8, 2022

Test failures seems unrelate XML, IO.Ports and Memory. The links are expired, so I started another test round to be sure.

@ericstj ericstj merged commit 5c06175 into dotnet:release/3.1 Mar 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-Infrastructure Servicing-approved Approved for servicing release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants