Disable native projects #399
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
MSLukeWest
approved these changes
Oct 23, 2024
MichaelSimons
approved these changes
Oct 23, 2024
Member
|
Just wondering, could this break the VMR or aren't we using the native projects in the product graph anywhere? |
Member
Author
Native projects (NetCoreCheck tool) aren't building in VMR as there are no consumers of this tool. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #398
Native projects are failing due to compiler mismatch between object file produced in the build and dependent lib file produced by
runtime. Per @MSLukeWest these projects can be disabled. If we ever need to build them again, it will be easy to re-enable them. Historically, compiler mismatch only existed during short period around .NET GA timeframe.Additionally I've updated the Signing.props file to allow empty sign list as there won't be any artifacts for signing in x86/arm64 builds. This follows existing pattern in
runtimeandaspnetcore.