Skip to content

Fix some workflow issues #2720

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 9, 2021
Merged

Fix some workflow issues #2720

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions eng/native/build-commons.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,9 @@ check_prereqs()

build_native()
{
eval "$__RepoRootDir/eng/native/version/copy_version_files.sh"
if [[ ! -e "$__RepoRootDir/artifacts/obj/_version.c" ]]; then
eval "$__RepoRootDir/eng/native/version/copy_version_files.sh"
fi
Copy link
Member Author

@am11 am11 Oct 30, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jkoritzinsky, in official build, we always build from clean repo so I assumed this won't be a problem.

Copy link
Member

@jkoritzinsky jkoritzinsky Oct 30, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes we always build from a clean clone for an official build.


targetOS="$1"
platformArch="$2"
Expand Down Expand Up @@ -257,7 +259,7 @@ while :; do
break
fi

lowerI="$(echo "$1" | tr "[:upper:]" "[:lower:]")"
lowerI="$(echo "${1/--/-}" | tr "[:upper:]" "[:lower:]")"
case "$lowerI" in
-\?|-h|--help)
usage
Expand Down