Skip to content

Improve lldb discovery for tests #3855

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 26, 2023
Merged

Improve lldb discovery for tests #3855

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 28 additions & 12 deletions eng/build.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -251,19 +251,35 @@ fi
if [[ "$__Test" == 1 ]]; then
if [[ "$__CrossBuild" == 0 ]]; then
if [[ -z "$LLDB_PATH" ]]; then
export LLDB_PATH="$(which lldb-3.9.1 2> /dev/null)"
if [[ -z "$LLDB_PATH" ]]; then
export LLDB_PATH="$(which lldb-3.9 2> /dev/null)"
if [[ -z "$LLDB_PATH" ]]; then
export LLDB_PATH="$(which lldb-4.0 2> /dev/null)"
if [[ -z "$LLDB_PATH" ]]; then
export LLDB_PATH="$(which lldb-5.0 2> /dev/null)"
if [[ -z "$LLDB_PATH" ]]; then
export LLDB_PATH="$(which lldb 2> /dev/null)"
fi
fi
fi
check_version_exists() {
desired_version=-1

# Set up the environment to be used for building with the desired debugger.
if command -v "lldb-$1.$2" > /dev/null; then
desired_version="-$1.$2"
elif command -v "lldb$1$2" > /dev/null; then
desired_version="$1$2"
elif command -v "lldb-$1$2" > /dev/null; then
desired_version="-$1$2"
fi

echo "$desired_version"
}

# note: clang versions higher than 6 do not have minor version in file name, if it is zero.
versions="16 15 14 13 12 11 10 9 8 7 6.0 5.0 4.0 3.9"
for version in $versions; do
_major="${version%%.*}"
[ -z "${version##*.*}" ] && _minor="${version#*.}"
desired_version="$(check_version_exists "$_major" "$_minor")"
if [ "$desired_version" != "-1" ]; then majorVersion="$_major"; break; fi
done

if [ -z "$majorVersion" ]; then
export LLDB_PATH="$(command -v "lldb")"
else
export LLDB_PATH="$(command -v "lldb$desired_version")"
fi
fi

if [[ -z "$GDB_PATH" ]]; then
Expand Down