Fix DAC verify signature issue #5470
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Running `clrstack` a second time after a verify DAC failure succeeds. Runtime.GetDacFilePath wasn't caching the verifySignature parameter so the DAC wasn't being verified once the dac path was cached. Verify the DAC path passed to the DBI entry points for the `clrstack -i` path in RuntimeWrapper.CreateCorDebugProcess. Display the ISettingsService values in both `runtimes` and `sosstatus`.
hoyosjs
reviewed
Apr 30, 2025
src/Microsoft.Diagnostics.DebugServices.Implementation/Runtime.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.Diagnostics.ExtensionCommands/Host/CommandFormatHelpers.cs
Show resolved
Hide resolved
hoyosjs
reviewed
May 2, 2025
src/Microsoft.Diagnostics.ExtensionCommands/Host/StatusCommand.cs
Outdated
Show resolved
Hide resolved
hoyosjs
reviewed
May 12, 2025
hoyosjs
approved these changes
May 12, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Running
clrstacka second time after a verify DAC failure succeeds.Runtime.GetDacFilePath wasn't caching the verifySignature parameter so the DAC wasn't being verified once the dac path was cached.
Verify the DAC path passed to the DBI entry points for the
clrstack -ipath in RuntimeWrapper.CreateCorDebugProcess.Display the ISettingsService values in both
runtimesandsosstatus.