-
Notifications
You must be signed in to change notification settings - Fork 876
fix: Doc comment <code> block is not rendered correctly
#10390
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5036f18 to
e1b692a
Compare
28b7390 to
050771d
Compare
yufeih
approved these changes
Dec 4, 2024
bd15b02 to
a65207a
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #10390 +/- ##
==========================================
+ Coverage 74.31% 79.35% +5.03%
==========================================
Files 536 547 +11
Lines 23189 23629 +440
Branches 4056 4062 +6
==========================================
+ Hits 17234 18751 +1517
+ Misses 4853 3709 -1144
- Partials 1102 1169 +67 ☔ View full report in Codecov by Sentry. |
a65207a to
9d60f58
Compare
daf616c to
c8d72a7
Compare
test(snapshot): update snapshots e1b692a
c8d72a7 to
fcad76e
Compare
This was referenced Jul 25, 2025
This was referenced Aug 5, 2025
This was referenced Aug 14, 2025
This was referenced Oct 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR intended to fix issue #10385
What's changed on this PR
XmlComment::ResolveCodemethod.And add
empty newlinebefore<code>tag.XmlCommentUnitTest.csexpectedstring )Other Changes
(It seems temporary workaround is not needed on latest docfx code)
#9736(and#9495/#9754)snapshot.ymlworkflow.