Skip to content

Conversation

StephenBonikowsky
Copy link
Member

@StephenBonikowsky StephenBonikowsky commented Jun 10, 2021

Related to #23561

Phase 1 is supposed to be the smallest possible set of changes to get the existing documentation mapped to the new TOC design.

The modifications to docs/fundamentals/toc.yml reflect this minimal set of changes.

These changes and additional content related changes are tracked with the Migration guide project.

Next steps are to make the content related changes as listed in the 'Phase 1' column of the project and start getting reviews and feedback.

Existing Migration Docs
Preview Migration Docs

@StephenBonikowsky StephenBonikowsky requested a review from adegeo June 10, 2021 17:00
@StephenBonikowsky StephenBonikowsky self-assigned this Jun 10, 2021
@StephenBonikowsky StephenBonikowsky requested a review from a team as a code owner June 10, 2021 17:00
@dotnet-bot dotnet-bot added this to the June 2021 milestone Jun 10, 2021
@StephenBonikowsky
Copy link
Member Author

@adegeo in the preview I am seeing the Migration > Create a porting plan > Project structure page doing something strange, the navigation pane on the left changes and I can't figure out why?

@adegeo
Copy link
Contributor

adegeo commented Jun 18, 2021

@StephenBonikowsky I have no idea :( by all accounts it should work fine.

@adegeo adegeo enabled auto-merge (squash) July 2, 2021 19:43
@adegeo adegeo merged commit 753ed6b into dotnet:main Jul 2, 2021
Youssef1313 pushed a commit to Youssef1313/docs that referenced this pull request Jul 5, 2021
* Update with the minimal changes needed to align existing content to the new TOC.

* Adding the new page 'tooling-requirements.md' and adding initial content to resolve dotnet#24568

* Created additional pages needed for Phase 1 modifying the TOC as needed.

* Created additional pages needed for Phase 1 modifying the TOC as needed.

* Update docs/core/porting/premigration-needed-changes.md

* Update docs/core/porting/premigration-needed-changes.md

* Add breaking change page.

* Add breaking change page.

* Update tooling requirements page based on feedback.

* Update breaking changes page.

* Update breaking changes page.

* Rename and move thepage about sdk, msbuild and vs versioning.

* Rename and move thepage about sdk, msbuild and vs versioning.

* Latest round of feedback updates.

* Latest round of feedback updates.

* Update docs/core/porting/breaking-changes.md

Co-authored-by: Andy (Steve) De George <[email protected]>

* Update breaking-changes.md

* Update versioning....md

* Upgrade porting-approaches.md

* Upgrade premigration-needed-changes.md

* Upgrade project-structure.md

* Upgrade unsupported-apis.md

* TOC naming changes

* Update docs/core/porting/project-structure.md

Co-authored-by: Andy (Steve) De George <[email protected]>

* Update docs/core/porting/project-structure.md

Co-authored-by: Andy (Steve) De George <[email protected]>

* Update porting-approaches.md

* Update premigration-needed-changes.md

Co-authored-by: Andy (Steve) De George <[email protected]>
Co-authored-by: Andy De George (adegeo) <[email protected]>
href: ../core/porting/upgrade-assistant-aspnetmvc.md
- name: Breaking changes
displayName: app compatibility
href: ../core/porting/breaking-changes.md
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@adegeo @StephenBonikowsky What was the inspiration behind replacing the link to the /core/compatibility TOC with a link to a new /core/porting/breaking-changes.md article? This effectively orphans the /core/compatibility TOC.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By TOC do you mean this "Types of compatibility" page? (https://learn.microsoft.com/en-us/dotnet/core/compatibility/categories)

If so, we still link to it from https://learn.microsoft.com/en-us/dotnet/core/porting/breaking-changes#types-of-compatibility

A lot changed so I can't give you reasoning for that specific change. There is a lot more content desired for the whole 'Migration guide' section but priorities and resourcing hasn't permitted getting back to it.

Copy link
Contributor

@gewarren gewarren Dec 22, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I meant "table of contents". The "compatibility" table of contents is separate to the main .NET table of contents, and so it needs to be linked from the main table of contents. But by understanding the thinking behind your change of linking to a new article, I can perhaps find a different place to link to it.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gewarren If I remember correctly, it was to too much open information, versus the guided philosophy of the new migration guide. Instead, a new "breaking changes" page for the migration guide was created to give context FIRST, and then if they desired, they can check out the breaking changes TOC. This way, they're not overwhelmed with "here are the 1000 types of breaking things you'll have to watch out for" which may sway them away from migrating off of .NET Framework.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants