Skip to content

Conversation

@gewarren
Copy link
Contributor

@gewarren gewarren commented Oct 22, 2021

Fixes #26603

Preview

@dotnet-bot dotnet-bot added this to the October 2021 milestone Oct 22, 2021
@gewarren gewarren requested review from a team, karelz and wfurt October 22, 2021 00:33
@karelz
Copy link
Member

karelz commented Oct 22, 2021

@wfurt can you please review it as well? Especially confirm, if it impacts only HttpClient and related APIs, or if it has impact beyond that (e.g. NegotiateStream). Thanks!

Copy link
Member

@wfurt wfurt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wfurt
Copy link
Member

wfurt commented Oct 22, 2021

Looks good and impacts only HttpClient. Links to to Kerberos and Negotiate did not work for me but that can be the preview site. Thanks @gewarren.

@gewarren gewarren merged commit 00ef5f1 into dotnet:main Oct 22, 2021
@gewarren gewarren deleted the spn-port branch October 22, 2021 19:40
@wfurt wfurt mentioned this pull request Oct 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Breaking change]: Remove port from SPN in Kerberos/Negotiate

4 participants