Add arm32 Debian 12 helix image #1041
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
And unset CRYPTOGRAPHY_DONT_BUILD_RUST. Versions 3.5+ of cryptography have a hard requirement on rust. Also match arm64v8 step ordering
jkoritzinsky
approved these changes
May 9, 2024
|
Ha! We should have predicted this one, particularly when we were talking about adding a new helix image today. |
richlander
approved these changes
May 9, 2024
|
My guess is that we have an OpenSSL3 incompatibility here looking at the error. I saw you pinned the runtime build to old tag. Good plan. |
mthalman
reviewed
May 9, 2024
There was a problem hiding this comment.
Error in build:
> [3/6] RUN ln -sf /usr/bin/python3 /usr/bin/python && python3 -m pip install virtualenv==20.17.1 --break-system-packages && python3 -m pip download --no-deps helix-scripts --index-url https://dnceng.pkgs.visualstudio.com/public/_packaging/helix-client-prod/pypi/simple && python3 -m pip install ./helix_scripts-*-py3-none-any.whl --break-system-packages:
250.8 host_arch = host_platform.rsplit("-", 1)[1]
250.8 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~^^^
250.8 IndexError: list index out of range
250.8 [end of output]
250.8
250.8 note: This error originates from a subprocess, and is likely not a problem with pip.
250.8 ERROR: Failed building wheel for cryptography
250.8 Successfully built psutil pycparser
250.8 Failed to build cryptography
250.8 ERROR: Could not build wheels for cryptography, which is required to install pyproject.toml-based projects
This was referenced May 9, 2024
sbomer
added a commit
to dotnet/runtime
that referenced
this pull request
May 13, 2024
Reverts the temporary fix from #102035, and switches to Debian 12 arm images added in dotnet/dotnet-buildtools-prereqs-docker#1041 for testing. This replaces the Ubuntu 18.04 arm images with Debian because building new Ubuntu 22.04 arm images is blocked on dotnet/dnceng#2808. Fixes #102030
sbomer
added a commit
to dotnet/runtime
that referenced
this pull request
May 22, 2024
This updates our linux arm32 build to build against a more recent glibc that supports _TIME_BITS (which we set to 64). Since openssl may be using either 32-bit or 64-bit time_t, this includes detection logic to determine which case we are in, and avoid passing time values that don't fit in 32 bits to openssl. The arm build image is updated to the latest version of the images added in dotnet/dotnet-buildtools-prereqs-docker#1037. The helix test images are updated to debian images added in dotnet/dotnet-buildtools-prereqs-docker#1041. Additional context: Additional context: Reintroduces the fix for Y2038 support on arm32 linux (#102059), which was reverted due to problems running against openssl built with _TIME_BITS=32. Fixes #101444 (both the originally reported issue, and the test failures mentioned in #101444 (comment)). Supports: #91826
steveharter
pushed a commit
to steveharter/runtime
that referenced
this pull request
May 28, 2024
This updates our linux arm32 build to build against a more recent glibc that supports _TIME_BITS (which we set to 64). Since openssl may be using either 32-bit or 64-bit time_t, this includes detection logic to determine which case we are in, and avoid passing time values that don't fit in 32 bits to openssl. The arm build image is updated to the latest version of the images added in dotnet/dotnet-buildtools-prereqs-docker#1037. The helix test images are updated to debian images added in dotnet/dotnet-buildtools-prereqs-docker#1041. Additional context: Additional context: Reintroduces the fix for Y2038 support on arm32 linux (dotnet#102059), which was reverted due to problems running against openssl built with _TIME_BITS=32. Fixes dotnet#101444 (both the originally reported issue, and the test failures mentioned in dotnet#101444 (comment)). Supports: dotnet#91826
Ruihan-Yin
pushed a commit
to Ruihan-Yin/runtime
that referenced
this pull request
May 30, 2024
Reverts the temporary fix from dotnet#102035, and switches to Debian 12 arm images added in dotnet/dotnet-buildtools-prereqs-docker#1041 for testing. This replaces the Ubuntu 18.04 arm images with Debian because building new Ubuntu 22.04 arm images is blocked on dotnet/dnceng#2808. Fixes dotnet#102030
Ruihan-Yin
pushed a commit
to Ruihan-Yin/runtime
that referenced
this pull request
May 30, 2024
This updates our linux arm32 build to build against a more recent glibc that supports _TIME_BITS (which we set to 64). Since openssl may be using either 32-bit or 64-bit time_t, this includes detection logic to determine which case we are in, and avoid passing time values that don't fit in 32 bits to openssl. The arm build image is updated to the latest version of the images added in dotnet/dotnet-buildtools-prereqs-docker#1037. The helix test images are updated to debian images added in dotnet/dotnet-buildtools-prereqs-docker#1041. Additional context: Additional context: Reintroduces the fix for Y2038 support on arm32 linux (dotnet#102059), which was reverted due to problems running against openssl built with _TIME_BITS=32. Fixes dotnet#101444 (both the originally reported issue, and the test failures mentioned in dotnet#101444 (comment)). Supports: dotnet#91826
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1037 updated the glibc baseline for our arm32 images, but we were still running tests on Debian 11 which has an older version, causing the failures in dotnet/runtime#102030. This adds a new Debian 12 image.