Skip to content

Conversation

@lbussell
Copy link
Member

Fixes #5687

16b1b3c is not the best solution to excluding zlib packages for .NET 9. I'm working on a better solution to all of the hardcoded package lists in ProductImageTests.cs. However it may be better to do that in a follow-up PR.

@lbussell lbussell requested a review from a team as a code owner July 19, 2024 22:59
@richlander
Copy link
Member

@carlossanlop @jkotas here is the E2E of the zlib change.

@carlossanlop
Copy link

@lbussell just wanted to share here that we will still need the system-installed zlib package in the following platforms: armv6, android, ios, tvos and maccatalyst.

We decide that in cmake using this variable: https://github.com/dotnet/runtime/blob/4d2d3d3ef5870483af9e821b3f315d1dcd8b1e7d/eng/native/configureplatform.cmake#L511-L516

And we find the system-installed package using this logic: https://github.com/dotnet/runtime/blob/4d2d3d3ef5870483af9e821b3f315d1dcd8b1e7d/src/native/libs/System.IO.Compression.Native/extra_libs.cmake#L6-L11

@lbussell
Copy link
Member Author

lbussell commented Jul 22, 2024

@lbussell just wanted to share here that we will still need the system-installed zlib package in the following platforms: armv6, android, ios, tvos and maccatalyst.

@carlossanlop We don't ship containers for any of those platforms, so we should be good 👍

Will we need system zlib for any SDK scenarios? Our tests seem OK but I want to make sure I'm not missing anything. It's likely that most or all of our SDK base images include system zlib by default. If that's the case we'd want to install it explicitly as a dependency so it can be updated for security releases.

@carlossanlop
Copy link

Will we need system zlib for any SDK scenarios?

I'm unfamiliar with the requirements/needs of the sdk repo. My naive assumption is that we would need the same requirements as runtime, but I'd rather confirm with someone more familiar with that repo.

@jkoritzinsky or @akoeplinger do you have an answer for this?

@jkotas
Copy link
Member

jkotas commented Jul 23, 2024

The SDK itself is a pure managed code. It should not have any direct dependencies on zlib.

Some tools or packages outside of SDK may have dependencies on zlib. If there are any tools or packages like that, I would say that it is a problem for those tools or packages to address. It does not make sense for us to carry unmanaged dependencies for them.

@richlander
Copy link
Member

Our lack of (package) dependency on zlib has also been documented now.

https://github.com/dotnet/core/blob/main/release-notes/9.0/os-packages.md

Fine question @carlossanlop. I think there is no reason to wait on merging.

@lbussell lbussell enabled auto-merge (squash) July 24, 2024 17:58
@lbussell lbussell merged commit ade8604 into dotnet:nightly Jul 24, 2024
lbussell added a commit to lbussell/dotnet-docker that referenced this pull request Aug 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants